From 864b4f2bfbb3a82a5c2ac60b52564db97bc5c7f6 Mon Sep 17 00:00:00 2001 From: Jamie <113370520+jamiebuilds-signal@users.noreply.github.com> Date: Tue, 3 Mar 2026 11:23:42 -0800 Subject: [PATCH] Prevent deleted messages from being pinned --- ts/messageModifiers/PinnedMessages.preload.ts | 4 ++++ ts/state/selectors/message.preload.ts | 3 +++ 2 files changed, 7 insertions(+) diff --git a/ts/messageModifiers/PinnedMessages.preload.ts b/ts/messageModifiers/PinnedMessages.preload.ts index 2fec799352..78c38fddd6 100644 --- a/ts/messageModifiers/PinnedMessages.preload.ts +++ b/ts/messageModifiers/PinnedMessages.preload.ts @@ -224,6 +224,10 @@ function validatePinnedMessageTarget( return { error: 'Sender does not have access to edit group attributes' }; } + if (message.deletedForEveryone) { + return { error: 'Cannot pin deleted message' }; + } + if (isGiftBadge(message)) { return { error: 'Cannot pin gift badge messages' }; } diff --git a/ts/state/selectors/message.preload.ts b/ts/state/selectors/message.preload.ts index 832a714e1d..fe46cd48c8 100644 --- a/ts/state/selectors/message.preload.ts +++ b/ts/state/selectors/message.preload.ts @@ -2622,6 +2622,9 @@ export function canPinMessage( if (!canPinMessages(conversation)) { return false; } + if (message.deletedForEveryone) { + return false; + } if (isGiftBadge(message)) { return false; }