From 8b6494ae6c9247acdfa059a9b361ec5ffcdb39f0 Mon Sep 17 00:00:00 2001 From: Daniel Gasienica Date: Tue, 13 Feb 2018 08:29:20 -0500 Subject: [PATCH] Document potentially unexpected `autoScale` behavior --- js/views/file_input_view.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/js/views/file_input_view.js b/js/views/file_input_view.js index 67acabb2d7..5aca2b03ed 100644 --- a/js/views/file_input_view.js +++ b/js/views/file_input_view.js @@ -108,6 +108,9 @@ canvas.toDataURL('image/jpeg', quality) ); quality = quality * maxSize / blob.size; + // NOTE: During testing with a large image, we observed the + // `quality` value being > 1. Should we clamp it to [0.5, 1.0]? + // See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toBlob#Syntax if (quality < 0.5) { quality = 0.5; }