From 8eaec167f788b83cf68a2231dd2cb07bbe1d6432 Mon Sep 17 00:00:00 2001 From: Jamie Kyle <113370520+jamiebuilds-signal@users.noreply.github.com> Date: Thu, 7 Aug 2025 12:32:14 -0700 Subject: [PATCH] Filter out SMS conversations with no messages from the contact results Co-authored-by: Wyatt Childers --- ts/state/ducks/search.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ts/state/ducks/search.ts b/ts/state/ducks/search.ts index dc49da9026..ae76065a32 100644 --- a/ts/state/ducks/search.ts +++ b/ts/state/ducks/search.ts @@ -46,6 +46,7 @@ import { removeDiacritics } from '../../util/removeDiacritics'; import { createLogger } from '../../logging/log'; import { searchConversationTitles } from '../../util/searchConversationTitles'; import { isDirectConversation } from '../../util/whatTypeOfConversation'; +import { isConversationSMSOnly } from '../../util/isConversationSMSOnly'; import { countConversationUnreadStats, hasUnread, @@ -568,7 +569,12 @@ async function queryConversationsAndContacts( const normalizedQuery = removeDiacritics(query); const visibleConversations = allConversations.filter(conversation => { - const { activeAt, removalStage, isBlocked, messagesDeleted } = conversation; + const { activeAt, removalStage, isBlocked, hasMessages, messagesDeleted } = + conversation; + + if (isConversationSMSOnly(conversation) && !hasMessages) { + return false; + } if (isDirectConversation(conversation)) { // if a conversation has messages (i.e. is not "deleted"), always show it