Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-25 10:58:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix handling attachment thumbnails using thumbnail key

Browse Source
This commit is contained in:
Scott Nonnenberg
2018-04-13 15:45:37 -07:00
parent 6413e75f82
commit 9ad55c803f
2 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test/modules/types/message_test.js
View File

@@ -358,6 +358,21 @@ describe('Message', () => {
assert.deepEqual(result, message);
});
it('handles attachments with no thumbnail', async () => {
const upgradeAttachment = sinon.stub().throws(new Error("Shouldn't be called"));
const upgradeVersion = Message._mapQuotedAttachments(upgradeAttachment);
const message = {
body: 'hey there!',
quote: {
text: 'hey!',
attachments: [],
},
};
const result = await upgradeVersion(message);
assert.deepEqual(result, message);
});
it('calls provided async function for each quoted attachment', async () => {
const upgradeAttachment = sinon.stub().resolves({
path: '/new/path/on/disk',
@@ -369,7 +384,9 @@ describe('Message', () => {
quote: {
text: 'hey!',
attachments: [{
data: 'data is here',
thumbnail: {
data: 'data is here',
},
}],
},
};
@@ -378,7 +395,9 @@ describe('Message', () => {
quote: {
text: 'hey!',
attachments: [{
path: '/new/path/on/disk',
thumbnail: {
path: '/new/path/on/disk',
},
}],
},
};