Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-27 03:43:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Index messages with attachments using a boolean

Browse Source 
When indexing message attachment metadata using numeric indexes such as:

```javascript
{
  conversationId: '+12223334455',
  received_at: 123,
  attachments: […],
  numAttachments: 2,
},
{
  conversationId: '+12223334455',
  received_at: 456,
  attachments: [],
  numAttachments: 0,
}
{
  conversationId: '+12223334455',
  received_at: 789,
  attachments: [],
  numAttachments: 1,
}
```

It creates an index as follows:

```
[conversationId, received_at, numAttachments]
['+12223334455', 123, 2]
['+12223334455', 456, 0]
['+12223334455', 789, 1]
```

This means a query such as…

```
lowerBound: ['+12223334455', 0,                1               ]
upperBound: ['+12223334455', Number.MAX_VALUE, Number.MAX_VALUE]
```

…will return all three original entries because they span the `received_at`
from `0` through `Number.MAX_VALUE`. One workaround is to index booleans using
`1 | undefined` where `1` is included in the index and `undefined` is not, but
that way we lose the ability to query for the `false` value. Instead, we flip
adjust the index to `[conversationId, hasAttachments, received_at]` and can
then query messages with attachments using

```
[conversationId, 1 /* hasAttachments */, 0                /* received_at */]
[conversationId, 1 /* hasAttachments */, Number.MAX_VALUE /* received_at */]
```
This commit is contained in:
Daniel Gasienica
2018-04-13 21:47:06 -04:00
parent c46e1a1519
commit 9d84b2f420
7 changed files with 42 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/modules/types/message.js
View File

@@ -24,9 +24,9 @@ const PRIVATE = 'private';
// - Quotes: Write thumbnail data to disk and store relative path to it.
// Version 5
// - Attachments: Track number and kind of attachments for media gallery
// - `numAttachments: Number`
// - `numVisualMediaAttachments: Number` (for media gallery ‘Media’ view)
// - `numFileAttachments: Number` (for media gallery ‘Documents’ view)
// - `hasAttachments?: 1 | undefined`
// - `hasVisualMediaAttachments?: 1 | undefined` (for media gallery ‘Media’ view)
// - `hasFileAttachments: ?1 | undefined` (for media gallery ‘Documents’ view)
const INITIAL_SCHEMA_VERSION = 0;