Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 20:26:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve message targeting for incoming reactions

Browse Source
This commit is contained in:
trevor-signal
2024-04-29 17:20:20 -04:00
committed by GitHub
parent f02a11bc9b
commit a0b4126b52
19 changed files with 769 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ts/messages/helpers.ts
View File

@@ -132,11 +132,11 @@ export function isQuoteAMatch(
return (
isSameTimestamp &&
message.conversationId === conversationId &&
getContactId(message) === authorConversation?.id
getAuthorId(message) === authorConversation?.id
);
}
export function getContactId(
export function getAuthorId(
message: Pick<MessageAttributesType, 'type' | 'source' | 'sourceServiceId'>
): string | undefined {
const source = getSource(message);
@@ -149,15 +149,15 @@ export function getContactId(
const conversation = window.ConversationController.lookupOrCreate({
e164: source,
serviceId: sourceServiceId,
reason: 'helpers.getContactId',
reason: 'helpers.getAuthorId',
});
return conversation?.id;
}
export function getContact(
export function getAuthor(
message: MessageAttributesType
): ConversationModel | undefined {
const id = getContactId(message);
const id = getAuthorId(message);
return window.ConversationController.get(id);
}