Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 12:19:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor number parsing and validation

Browse Source 
Refactor libphonenumber.validateNumber into libphonenumber.parseNumber,
which encapsulates the try-catch pattern used in number parsing and
returns an object of info about the input number rather tha throwing
since we expect to get some invalid number inputs the user is typing.

In the conversation model,
  * Separate phone number validation from search token updating.
  * Perform token update before save if the number was valid.
  * Stop storing unneeded number variants as conversation properties.

// FREEBIE
This commit is contained in:
lilia
2015-12-04 17:38:41 -08:00
parent 7dd0fb70b5
commit a258f1a66b
6 changed files with 105 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
js/libphonenumber-util.js
View File

@@ -34,20 +34,19 @@
return (cc !== 0) ? cc : "";
},
verifyNumber: function(number, regionCode) {
var parsedNumber = libphonenumber.parse(number, regionCode);
parseNumber: function(number, defaultRegionCode) {
try {
var parsedNumber = libphonenumber.parse(number, defaultRegionCode);
if(!regionCode || regionCode == 'ZZ') {
regionCode = libphonenumber.getRegionCodeForNumber(parsedNumber);
}
var isValidNumber = libphonenumber.isValidNumber(parsedNumber);
var isValidNumberForRegion = libphonenumber.isValidNumberForRegion(parsedNumber, regionCode);
if (isValidNumber && isValidNumberForRegion) {
return libphonenumber.format(parsedNumber, libphonenumber.PhoneNumberFormat.E164);
} else {
throw new Error("The number seems not to be valid.");
return {
isValidNumber: libphonenumber.isValidNumber(parsedNumber),
regionCode: libphonenumber.getRegionCodeForNumber(parsedNumber),
countryCode: '' + parsedNumber.getCountryCode(),
nationalNumber: '' + parsedNumber.getNationalNumber(),
e164: libphonenumber.format(parsedNumber, libphonenumber.PhoneNumberFormat.E164)
};
} catch (ex) {
return { error: ex, isValidNumber: false };
}
},