Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 20:26:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compose: Show 'search for username' by itself more often

Browse Source
This commit is contained in:
Scott Nonnenberg
2025-03-19 01:41:52 +10:00
committed by GitHub
parent 5e825e03ba
commit a3335929b3
4 changed files with 134 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
ts/test-node/components/leftPane/LeftPaneComposeHelper_test.ts
View File

@@ -82,7 +82,7 @@ describe('LeftPaneComposeHelper', () => {
);
});
it('returns the number of contacts, number groups + 4 (for headers and username)', () => {
it('returns two if the search term looks like a username', () => {
assert.strictEqual(
new LeftPaneComposeHelper({
composeContacts: [getDefaultConversation(), getDefaultConversation()],
@@ -92,6 +92,45 @@ describe('LeftPaneComposeHelper', () => {
uuidFetchState: {},
username: 'someone.01',
}).getRowCount(),
2,
'ends with discriminator'
);
assert.strictEqual(
new LeftPaneComposeHelper({
composeContacts: [getDefaultConversation(), getDefaultConversation()],
composeGroups: [getDefaultGroupListItem(), getDefaultGroupListItem()],
regionCode: 'US',
searchTerm: '@someone',
uuidFetchState: {},
username: 'someone',
}).getRowCount(),
2,
'starts with @'
);
assert.strictEqual(
new LeftPaneComposeHelper({
composeContacts: [getDefaultConversation(), getDefaultConversation()],
composeGroups: [getDefaultGroupListItem(), getDefaultGroupListItem()],
regionCode: 'US',
searchTerm: '23432',
uuidFetchState: {},
username: '23432',
}).getRowCount(),
8,
"all numbers, so it doesn't look like a username"
);
});
it('returns the number of contacts, number groups + 4 (for headers and username)', () => {
assert.strictEqual(
new LeftPaneComposeHelper({
composeContacts: [getDefaultConversation(), getDefaultConversation()],
composeGroups: [getDefaultGroupListItem(), getDefaultGroupListItem()],
regionCode: 'US',
searchTerm: 'someone',
uuidFetchState: {},
username: 'someone',
}).getRowCount(),
8
);
});
@@ -102,9 +141,9 @@ describe('LeftPaneComposeHelper', () => {
composeContacts: [],
composeGroups: [],
regionCode: 'US',
searchTerm: 'foobar.01',
searchTerm: '5550101',
uuidFetchState: {},
username: 'foobar.01',
username: undefined,
}).getRowCount(),
2
);
@@ -113,9 +152,9 @@ describe('LeftPaneComposeHelper', () => {
composeContacts: [getDefaultConversation(), getDefaultConversation()],
composeGroups: [],
regionCode: 'US',
searchTerm: 'foobar.01',
searchTerm: '5550101',
uuidFetchState: {},
username: 'foobar.01',
username: undefined,
}).getRowCount(),
5
);
@@ -124,9 +163,9 @@ describe('LeftPaneComposeHelper', () => {
composeContacts: [getDefaultConversation(), getDefaultConversation()],
composeGroups: [getDefaultGroupListItem()],
regionCode: 'US',
searchTerm: 'foobar.01',
searchTerm: '5550101',
uuidFetchState: {},
username: 'foobar.01',
username: undefined,
}).getRowCount(),
7
);
@@ -152,9 +191,9 @@ describe('LeftPaneComposeHelper', () => {
composeContacts: [],
composeGroups: [],
regionCode: 'US',
searchTerm: 'someone.02',
searchTerm: 'someone',
uuidFetchState: {},
username: 'someone.02',
username: 'someone',
}).getRowCount(),
2
);