Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 20:26:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add CallLinkDeleteManager to retry and ensure deletion

Browse Source
This commit is contained in:
ayumi-signal
2024-09-16 12:22:01 -07:00
committed by GitHub
parent 8b627b3f1a
commit a40d54099c
8 changed files with 229 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ts/sql/Interface.ts
View File

@@ -586,7 +586,7 @@ type ReadableInterface = {
getCallLinkByRoomId: (roomId: string) => CallLinkType | undefined;
getCallLinkRecordByRoomId: (roomId: string) => CallLinkRecord | undefined;
getAllCallLinkRecordsWithAdminKey(): ReadonlyArray<CallLinkRecord>;
getAllMarkedDeletedCallLinks(): ReadonlyArray<CallLinkType>;
getAllMarkedDeletedCallLinkRoomIds(): ReadonlyArray<string>;
getMessagesBetween: (
conversationId: string,
options: GetMessagesBetweenOptions

4
ts/sql/Server.ts
View File

@@ -181,7 +181,7 @@ import {
updateCallLinkState,
beginDeleteAllCallLinks,
getAllCallLinkRecordsWithAdminKey,
getAllMarkedDeletedCallLinks,
getAllMarkedDeletedCallLinkRoomIds,
finalizeDeleteCallLink,
beginDeleteCallLink,
deleteCallLinkFromSync,
@@ -313,7 +313,7 @@ export const DataReader: ServerReadableInterface = {
getCallLinkByRoomId,
getCallLinkRecordByRoomId,
getAllCallLinkRecordsWithAdminKey,
getAllMarkedDeletedCallLinks,
getAllMarkedDeletedCallLinkRoomIds,
getMessagesBetween,
getNearbyMessageFromDeletedSet,
getMostRecentAddressableMessages,

11
ts/sql/server/callLinks.ts
View File

@@ -305,16 +305,13 @@ export function getAllCallLinkRecordsWithAdminKey(
.map(item => callLinkRecordSchema.parse(item));
}
export function getAllMarkedDeletedCallLinks(
export function getAllMarkedDeletedCallLinkRoomIds(
db: ReadableDB
): ReadonlyArray<CallLinkType> {
): ReadonlyArray<string> {
const [query] = sql`
SELECT * FROM callLinks WHERE deleted = 1;
SELECT roomId FROM callLinks WHERE deleted = 1;
`;
return db
.prepare(query)
.all()
.map(item => callLinkFromRecord(callLinkRecordSchema.parse(item)));
return db.prepare(query).pluck().all();
}
// TODO: Run this after uploading storage records, maybe periodically on startup