Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-18 23:49:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Deduplicate incoming stickers from installed sticker packs

Browse Source
This commit is contained in:
trevor-signal
2026-02-12 12:36:53 -05:00
committed by GitHub
parent 95f131efbf
commit ae90a74cef
8 changed files with 235 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
ts/test-mock/storage/sticker_test.node.ts
View File

@@ -14,10 +14,15 @@ import {
getStickerPackRecordPredicate,
getStickerPackLink,
} from './fixtures.node.js';
import {
getMessageInTimelineByTimestamp,
sendTextMessage,
} from '../helpers.node.js';
import { strictAssert } from '../../util/assert.std.js';
const { StickerPackOperation } = Proto.SyncMessage;
describe('storage service', function (this: Mocha.Suite) {
describe('stickers', function (this: Mocha.Suite) {
this.timeout(durations.MINUTE);
let bootstrap: Bootstrap;
@@ -251,5 +256,56 @@ describe('storage service', function (this: Mocha.Suite) {
const finalState = await phone.expectStorageState('consistency check');
assert.strictEqual(finalState.version, 5);
debug(
'verifying that stickers from packs can be received and paths are deduplicated'
);
const firstTimestamp = bootstrap.getTimestamp();
const secondTimestamp = bootstrap.getTimestamp();
await sendTextMessage({
from: firstContact,
to: desktop,
desktop,
text: undefined,
sticker: {
packId: STICKER_PACKS[0].id,
packKey: STICKER_PACKS[0].key,
stickerId: 0,
},
timestamp: firstTimestamp,
});
await sendTextMessage({
from: firstContact,
to: desktop,
desktop,
text: undefined,
sticker: {
packId: STICKER_PACKS[0].id,
packKey: STICKER_PACKS[0].key,
stickerId: 0,
},
timestamp: secondTimestamp,
});
await window.getByRole('button', { name: 'Go back' }).click();
await getMessageInTimelineByTimestamp(window, firstTimestamp)
.locator('.module-image--loaded')
.waitFor();
await getMessageInTimelineByTimestamp(window, secondTimestamp)
.locator('.module-image--loaded')
.waitFor();
const firstStickerData = (await app.getMessagesBySentAt(firstTimestamp))[0]
.sticker?.data;
const secondStickerData = (
await app.getMessagesBySentAt(secondTimestamp)
)[0].sticker?.data;
strictAssert(firstStickerData?.path, 'path exists');
strictAssert(firstStickerData?.localKey, 'localKey exists');
assert.strictEqual(firstStickerData.path, secondStickerData?.path);
assert.strictEqual(firstStickerData.localKey, secondStickerData?.localKey);
});
});