From bf2b257736fbc78b144bd0f48a9d2e9e68dcd0a6 Mon Sep 17 00:00:00 2001
From: Jamie <113370520+jamiebuilds-signal@users.noreply.github.com>
Date: Wed, 21 Jan 2026 12:06:26 -0800
Subject: [PATCH] Fix pin message dialog submit with no warning step

---
 .../pinned-messages/PinMessageDialog.dom.tsx  | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/ts/components/conversation/pinned-messages/PinMessageDialog.dom.tsx b/ts/components/conversation/pinned-messages/PinMessageDialog.dom.tsx
index 2f5619c379..b6483f70fa 100644
--- a/ts/components/conversation/pinned-messages/PinMessageDialog.dom.tsx
+++ b/ts/components/conversation/pinned-messages/PinMessageDialog.dom.tsx
@@ -93,34 +93,34 @@ export const PinMessageDialog = memo(function PinMessageDialog(
     [onOpenChange]
   );
 
-  const submit = useCallback(() => {
-    strictAssert(
-      duration != null,
-      'Duration should not be null when submitting'
-    );
-    const durationValue = DURATION_OPTIONS[duration];
-    onPinnedMessageAdd(messageId, durationValue);
-    handleOpenChange(false);
-  }, [onPinnedMessageAdd, messageId, duration, handleOpenChange]);
+  const submit = useCallback(
+    (selectedDuration: DurationOption) => {
+      const durationValue = DURATION_OPTIONS[selectedDuration];
+      onPinnedMessageAdd(messageId, durationValue);
+      handleOpenChange(false);
+    },
+    [onPinnedMessageAdd, messageId, handleOpenChange]
+  );
 
   const handleConfirmReplaceOldestPin = useCallback(() => {
     setConfirmedReplaceOldestPin(true);
   }, []);
 
   const handleSelectDuration = useCallback(
-    (selected: DurationOption) => {
-      setDuration(selected);
+    (selectedDuration: DurationOption) => {
+      setDuration(selectedDuration);
       if (!needsConfirmDisappearingMessages) {
-        submit();
+        submit(selectedDuration);
       }
     },
     [needsConfirmDisappearingMessages, submit]
   );
 
   const handleConfirmDisappearingMessages = useCallback(() => {
+    strictAssert(duration != null, 'Duration should not be null');
     onSeenPinMessageDisappearingMessagesWarning();
-    submit();
-  }, [onSeenPinMessageDisappearingMessagesWarning, submit]);
+    submit(duration);
+  }, [onSeenPinMessageDisappearingMessagesWarning, duration, submit]);
 
   let step: Step;
   if (!props.open) {