From c83efc3b6e460816fc497aa52fa48258554fdba1 Mon Sep 17 00:00:00 2001 From: Jamie <113370520+jamiebuilds-signal@users.noreply.github.com> Date: Fri, 22 May 2026 07:12:56 -0700 Subject: [PATCH] Update all type methods to use property syntax --- ts/CI.preload.ts | 18 +- ts/SignalProtocolStore.preload.ts | 2 +- ts/challenge.dom.ts | 18 +- ts/components/CompositionArea.dom.tsx | 30 +-- ts/components/CompositionInput.dom.tsx | 14 +- ...CustomizingPreferredReactionsModal.dom.tsx | 12 +- ts/components/DisappearingTimerSelect.dom.tsx | 2 +- ts/components/ForwardMessagesModal.dom.tsx | 2 +- ts/components/IncomingCallBar.dom.tsx | 8 +- ts/components/LeftPane.dom.tsx | 2 +- ts/components/NavSidebar.dom.tsx | 2 +- ts/components/NavTabs.dom.tsx | 4 +- ts/components/SafetyTipsModal.dom.tsx | 2 +- ts/components/Select.dom.tsx | 2 +- ts/components/SimpleQuillWrapper.dom.tsx | 2 +- ts/components/StoriesSettingsModal.dom.tsx | 14 +- ts/components/UsernameEditor.dom.tsx | 12 +- .../VoiceNotesPlaybackContext.dom.tsx | 2 +- .../conversation/ErrorBoundary.dom.tsx | 2 +- ts/components/conversation/GIF.dom.tsx | 8 +- .../conversation/MessageAudio.dom.tsx | 8 +- .../MessageRequestActionsConfirmation.dom.tsx | 12 +- ...MessageRequestResponseNotification.dom.tsx | 4 +- ts/context/createNativeThemeListener.std.ts | 8 +- ts/hooks/useScrollLock.dom.tsx | 8 +- ts/hooks/useSizeObserver.dom.tsx | 2 +- ts/jobs/JobQueueDatabaseStore.preload.ts | 6 +- ts/jobs/types.std.ts | 8 +- ts/main/powerChannel.main.ts | 2 +- ts/messages/copyQuote.preload.ts | 11 +- ts/models/conversations.preload.ts | 2 +- ts/mp4box.d.ts | 4 +- ts/services/ActiveWindowService.std.ts | 10 +- .../addGlobalKeyboardShortcuts.preload.ts | 2 +- ts/services/calling.preload.ts | 2 +- ts/services/keyboardLayout.dom.ts | 4 +- .../releaseNoteAndMegaphoneFetcher.preload.ts | 2 +- ts/sql/Interface.std.ts | 204 +++++++++--------- ts/state/smart/LeftPane.preload.tsx | 2 +- ts/state/smart/UsernameEditor.preload.tsx | 2 +- ts/textsecure/Types.d.ts | 4 +- ts/textsecure/UpdateKeysListener.preload.ts | 2 +- ts/textsecure/WebsocketResources.preload.ts | 12 +- ts/textsecure/cds/CDSBase.node.ts | 2 +- ts/types/Storage.d.ts | 17 +- ts/types/Util.std.ts | 14 +- ts/util/AbortableProcess.std.ts | 2 +- ts/util/StartupQueue.std.ts | 2 +- ts/util/desktopCapturer.preload.ts | 6 +- ts/util/getStreamWithTimeout.node.ts | 2 +- ts/util/signalRoutes.std.ts | 17 +- ts/window.d.ts | 35 +-- ts/workers/mp3Encoder.std.ts | 2 +- 53 files changed, 295 insertions(+), 283 deletions(-) diff --git a/ts/CI.preload.ts b/ts/CI.preload.ts index 70598d58ca..a9af4155b3 100644 --- a/ts/CI.preload.ts +++ b/ts/CI.preload.ts @@ -30,9 +30,9 @@ export type CIType = { deviceName: string; getConversationId: (address: string | null) => string | null; createNotificationToken: (address: string) => string | undefined; - getMessagesBySentAt( + getMessagesBySentAt: ( sentAt: number - ): Promise>; + ) => Promise>; getPendingEventCount: (event: string) => number; getSocketStatus: () => SocketStatuses; handleEvent: (event: string, data: unknown) => unknown; @@ -46,16 +46,16 @@ export type CIType = { ignorePastEvents?: boolean; } ) => unknown; - openSignalRoute(url: string): Promise; - migrateAllMessages(): Promise; - exportLocalBackup(backupsBaseDir: string): Promise; - stageLocalBackupForImport(snapshotDir: string): Promise; - uploadBackup(): Promise; + openSignalRoute: (url: string) => Promise; + migrateAllMessages: () => Promise; + exportLocalBackup: (backupsBaseDir: string) => Promise; + stageLocalBackupForImport: (snapshotDir: string) => Promise; + uploadBackup: () => Promise; unlink: () => void; print: (...args: ReadonlyArray) => void; - resetReleaseNoteAndMegaphoneFetcher(): void; + resetReleaseNoteAndMegaphoneFetcher: () => void; forceUnprocessed: boolean; - setMediaPermissions(): Promise; + setMediaPermissions: () => Promise; maybeUpdateMaxAudioLevel: (level: number) => void; getAndResetMaxAudioLevel: () => number | undefined; }; diff --git a/ts/SignalProtocolStore.preload.ts b/ts/SignalProtocolStore.preload.ts index dc6514b9d8..4f708992c1 100644 --- a/ts/SignalProtocolStore.preload.ts +++ b/ts/SignalProtocolStore.preload.ts @@ -235,7 +235,7 @@ type SenderKeyCacheEntry = CacheEntryType; type ZoneQueueEntryType = Readonly<{ zone: Zone; - callback(): void; + callback: () => void; }>; export class SignalProtocolStore extends EventEmitter { diff --git a/ts/challenge.dom.ts b/ts/challenge.dom.ts index ed6d3d4533..4f110b8f54 100644 --- a/ts/challenge.dom.ts +++ b/ts/challenge.dom.ts @@ -44,8 +44,8 @@ export type IPCResponse = Readonly<{ type Handler = Readonly<{ token: string | undefined; - resolve(response: ChallengeResponse): void; - reject(error: Error): void; + resolve: (response: ChallengeResponse) => void; + reject: (error: Error) => void; }>; export type ChallengeData = Readonly<{ @@ -57,16 +57,18 @@ export type ChallengeData = Readonly<{ export type Options = Readonly<{ storage: Pick; - requestChallenge(request: IPCRequest): void; + requestChallenge: (request: IPCRequest) => void; - startQueue(conversationId: string): void; + startQueue: (conversationId: string) => void; - sendChallengeResponse(data: ChallengeData): Promise; + sendChallengeResponse: (data: ChallengeData) => Promise; - setChallengeStatus(challengeStatus: 'idle' | 'required' | 'pending'): void; + setChallengeStatus: ( + challengeStatus: 'idle' | 'required' | 'pending' + ) => void; - onChallengeSolved(): void; - onChallengeFailed(retryAfter?: number): void; + onChallengeSolved: () => void; + onChallengeFailed: (retryAfter?: number) => void; expireAfter?: number; }>; diff --git a/ts/components/CompositionArea.dom.tsx b/ts/components/CompositionArea.dom.tsx index f8fe819540..2f77032764 100644 --- a/ts/components/CompositionArea.dom.tsx +++ b/ts/components/CompositionArea.dom.tsx @@ -144,8 +144,8 @@ export type OwnProps = Readonly<{ left: boolean | null; linkPreviewLoading: boolean; linkPreviewResult: LinkPreviewForUIType | null; - onClearAttachments(conversationId: string): unknown; - onCloseLinkPreview(conversationId: string): unknown; + onClearAttachments: (conversationId: string) => unknown; + onCloseLinkPreview: (conversationId: string) => unknown; platform: string; showToast: ShowToastAction; processAttachments: (options: { @@ -153,12 +153,12 @@ export type OwnProps = Readonly<{ files: ReadonlyArray; flags: number | null; }) => unknown; - setMediaQualitySetting(conversationId: string, isHQ: boolean): unknown; - sendStickerMessage( + setMediaQualitySetting: (conversationId: string, isHQ: boolean) => unknown; + sendStickerMessage: ( id: string, opts: { packId: string; stickerId: number } - ): unknown; - sendEditedMessage( + ) => unknown; + sendEditedMessage: ( conversationId: string, options: { bodyRanges?: DraftBodyRanges; @@ -167,8 +167,8 @@ export type OwnProps = Readonly<{ quoteSentAt?: number; targetMessageId: string; } - ): unknown; - sendMultiMediaMessage( + ) => unknown; + sendMultiMediaMessage: ( conversationId: string, options: { draftAttachments?: ReadonlyArray; @@ -178,8 +178,8 @@ export type OwnProps = Readonly<{ timestamp?: number; voiceNoteAttachment?: InMemoryAttachmentDraftType; } - ): unknown; - sendPoll(conversationId: string, poll: PollCreateType): unknown; + ) => unknown; + sendPoll: (conversationId: string, poll: PollCreateType) => unknown; quotedMessageId: string | null; quotedMessageProps: null | ReadonlyDeep< Omit< @@ -196,17 +196,17 @@ export type OwnProps = Readonly<{ ) => unknown; scrollToMessage: (conversationId: string, messageId: string) => unknown; setComposerFocus: (conversationId: string) => unknown; - setMessageToEdit(conversationId: string, messageId: string): unknown; - setQuoteByMessageId( + setMessageToEdit: (conversationId: string, messageId: string) => unknown; + setQuoteByMessageId: ( conversationId: string, messageId: string | undefined - ): unknown; + ) => unknown; isViewOnce: boolean; - setViewOnce(options: { + setViewOnce: (options: { conversationId: string; value: boolean; toastNotify: boolean; - }): unknown; + }) => unknown; shouldSendHighQualityAttachments: boolean; showConversation: ShowConversationType; warmupRecording: () => void; diff --git a/ts/components/CompositionInput.dom.tsx b/ts/components/CompositionInput.dom.tsx index 72a3561511..05b5966c6c 100644 --- a/ts/components/CompositionInput.dom.tsx +++ b/ts/components/CompositionInput.dom.tsx @@ -147,23 +147,23 @@ export type Props = Readonly<{ theme: ThemeType; placeholder?: string; sortedGroupMembers: ReadonlyArray | null; - onDirtyChange?(dirty: boolean): unknown; - onEditorStateChange(options: { + onDirtyChange?: (dirty: boolean) => unknown; + onEditorStateChange: (options: { bodyRanges: DraftBodyRanges; caretLocation?: number; conversationId: string | undefined; messageText: string; sendCounter: number; - }): unknown; - onTextTooLong(): unknown; + }) => unknown; + onTextTooLong: () => unknown; onSelectEmoji: (emojiSelection: FunEmojiSelection) => void; onBlur?: () => unknown; onFocus?: () => unknown; - onSubmit( + onSubmit: ( message: string, bodyRanges: DraftBodyRanges, timestamp: number - ): unknown; + ) => unknown; onScroll?: (ev: UIEvent) => void; ourConversationId: string | undefined; platform: string; @@ -171,7 +171,7 @@ export type Props = Readonly<{ shouldHidePopovers: boolean | null; linkPreviewLoading?: boolean; linkPreviewResult: LinkPreviewForUIType | null; - onCloseLinkPreview?(conversationId: string): unknown; + onCloseLinkPreview?: (conversationId: string) => unknown; showViewOnceButton: boolean; isViewOnceActive: boolean; onToggleViewOnce: () => void; diff --git a/ts/components/CustomizingPreferredReactionsModal.dom.tsx b/ts/components/CustomizingPreferredReactionsModal.dom.tsx index dd1b6a8628..7172fbf5bb 100644 --- a/ts/components/CustomizingPreferredReactionsModal.dom.tsx +++ b/ts/components/CustomizingPreferredReactionsModal.dom.tsx @@ -28,13 +28,13 @@ export type PropsType = { selectedDraftEmojiIndex: undefined | number; emojiSkinToneDefault: Emoji.SkinTone | null; - cancelCustomizePreferredReactionsModal(): unknown; - deselectDraftEmoji(): unknown; + cancelCustomizePreferredReactionsModal: () => unknown; + deselectDraftEmoji: () => unknown; onEmojiSkinToneDefaultChange: (emojiSkinToneDefault: Emoji.SkinTone) => void; - replaceSelectedDraftEmoji(newEmoji: Emoji.Variant): unknown; - resetDraftEmoji(): unknown; - savePreferredReactions(): unknown; - selectDraftEmojiToBeReplaced(index: number): unknown; + replaceSelectedDraftEmoji: (newEmoji: Emoji.Variant) => unknown; + resetDraftEmoji: () => unknown; + savePreferredReactions: () => unknown; + selectDraftEmojiToBeReplaced: (index: number) => unknown; }; export function CustomizingPreferredReactionsModal({ diff --git a/ts/components/DisappearingTimerSelect.dom.tsx b/ts/components/DisappearingTimerSelect.dom.tsx index cca46bf4c5..38c0806abb 100644 --- a/ts/components/DisappearingTimerSelect.dom.tsx +++ b/ts/components/DisappearingTimerSelect.dom.tsx @@ -15,7 +15,7 @@ export type Props = { disabled?: boolean; value?: DurationInSeconds; - onChange(value: DurationInSeconds): void; + onChange: (value: DurationInSeconds) => void; }; export function DisappearingTimerSelect(props: Props): JSX.Element { diff --git a/ts/components/ForwardMessagesModal.dom.tsx b/ts/components/ForwardMessagesModal.dom.tsx index 2959193875..0914d8fd37 100644 --- a/ts/components/ForwardMessagesModal.dom.tsx +++ b/ts/components/ForwardMessagesModal.dom.tsx @@ -418,7 +418,7 @@ export function ForwardMessagesModal({ type ForwardMessageEditorProps = Readonly<{ draft: MessageForwardDraft; linkPreview: LinkPreviewForUIType | null | void; - removeLinkPreview(): void; + removeLinkPreview: () => void; RenderCompositionTextArea: ComponentType; onChange: ( messageText: string, diff --git a/ts/components/IncomingCallBar.dom.tsx b/ts/components/IncomingCallBar.dom.tsx index 4353561feb..6590abce17 100644 --- a/ts/components/IncomingCallBar.dom.tsx +++ b/ts/components/IncomingCallBar.dom.tsx @@ -44,13 +44,13 @@ export type PropsType = { | 'title' | 'type' >; - bounceAppIconStart(): unknown; - bounceAppIconStop(): unknown; - notifyForCall( + bounceAppIconStart: () => unknown; + bounceAppIconStop: () => unknown; + notifyForCall: ( conversationId: string, conversationTitle: string, isVideoCall: boolean - ): unknown; + ) => unknown; } & ( | { callMode: CallMode.Direct; diff --git a/ts/components/LeftPane.dom.tsx b/ts/components/LeftPane.dom.tsx index e15e69ca33..6f69dc108c 100644 --- a/ts/components/LeftPane.dom.tsx +++ b/ts/components/LeftPane.dom.tsx @@ -210,7 +210,7 @@ export type PropsType = { renderUpdateDialog: ( _: Readonly<{ containerWidthBreakpoint: WidthBreakpoint }> ) => JSX.Element; - renderCaptchaDialog: (props: { onSkip(): void }) => JSX.Element; + renderCaptchaDialog: (props: { onSkip: () => void }) => JSX.Element; renderCrashReportDialog: () => JSX.Element; renderExpiredBuildDialog: (_: DialogExpiredBuildPropsType) => JSX.Element; renderLeftPaneChatFolders: () => JSX.Element; diff --git a/ts/components/NavSidebar.dom.tsx b/ts/components/NavSidebar.dom.tsx index 985370259e..d076891640 100644 --- a/ts/components/NavSidebar.dom.tsx +++ b/ts/components/NavSidebar.dom.tsx @@ -62,7 +62,7 @@ export type NavSidebarProps = Readonly<{ hideHeader?: boolean; navTabsCollapsed: boolean; onBack?: (() => void) | null; - onToggleNavTabsCollapse(navTabsCollapsed: boolean): void; + onToggleNavTabsCollapse: (navTabsCollapsed: boolean) => void; preferredLeftPaneWidth: number; requiresFullWidth: boolean; savePreferredLeftPaneWidth: (width: number) => void; diff --git a/ts/components/NavTabs.dom.tsx b/ts/components/NavTabs.dom.tsx index 738e80cde1..bc4fde1ef7 100644 --- a/ts/components/NavTabs.dom.tsx +++ b/ts/components/NavTabs.dom.tsx @@ -128,7 +128,7 @@ export type NavTabPanelProps = Readonly<{ collapsed: boolean; hasFailedStorySends: boolean; hasPendingUpdate: boolean; - onToggleCollapse(collapsed: boolean): void; + onToggleCollapse: (collapsed: boolean) => void; }>; export type NavTabsToggleProps = Readonly<{ @@ -137,7 +137,7 @@ export type NavTabsToggleProps = Readonly<{ hasFailedStorySends: boolean; hasPendingUpdate: boolean; navTabsCollapsed: boolean; - onToggleNavTabsCollapse(navTabsCollapsed: boolean): void; + onToggleNavTabsCollapse: (navTabsCollapsed: boolean) => void; }>; export function NavTabsToggle({ diff --git a/ts/components/SafetyTipsModal.dom.tsx b/ts/components/SafetyTipsModal.dom.tsx index bc5d6d8bc4..485068591a 100644 --- a/ts/components/SafetyTipsModal.dom.tsx +++ b/ts/components/SafetyTipsModal.dom.tsx @@ -11,7 +11,7 @@ import { AxoButton } from '../axo/AxoButton.dom.tsx'; export type SafetyTipsModalProps = Readonly<{ i18n: LocalizerType; - onClose(): void; + onClose: () => void; }>; export function SafetyTipsModal({ diff --git a/ts/components/Select.dom.tsx b/ts/components/Select.dom.tsx index ca417b9d05..834700b384 100644 --- a/ts/components/Select.dom.tsx +++ b/ts/components/Select.dom.tsx @@ -18,7 +18,7 @@ export type PropsType = Readonly<{ moduleClassName?: string; name?: string; options: ReadonlyArray