Always share profile on send; no profile sharing UI if no messages

ts/services/storage.ts

@@ -1,4 +1,4 @@
-import _ from 'lodash';
+import { debounce, isNumber, partition } from 'lodash';
 import pMap from 'p-map';
 
 import Crypto from '../textsecure/Crypto';
@@ -753,7 +753,7 @@ async function processManifest(
 
   // Merge Account records last
   const sortedStorageItems = ([] as Array<MergeableItemType>).concat(
-    ..._.partition(
+    ...partition(
       decryptedStorageItems,
       storageRecord => storageRecord.storageRecord.account === undefined
     )
@@ -897,7 +897,14 @@ async function sync(): Promise<void> {
   window.log.info('storageService.sync: starting...');
 
   try {
-    const localManifestVersion = window.storage.get('manifestVersion') || 0;
+    // If we've previously interacted with strage service, update 'fetchComplete' record
+    const previousFetchComplete = window.storage.get('storageFetchComplete');
+    const manifestFromStorage = window.storage.get('manifestVersion');
+    if (!previousFetchComplete && isNumber(manifestFromStorage)) {
+      window.storage.put('storageFetchComplete', true);
+    }
+
+    const localManifestVersion = manifestFromStorage || 0;
     const manifest = await fetchManifest(localManifestVersion);
 
     // Guarding against no manifests being returned, everything should be ok
@@ -918,6 +925,9 @@ async function sync(): Promise<void> {
     if (hasConflicts) {
       await upload();
     }
+
+    // We now know that we've successfully completed a storage service fetch
+    window.storage.put('storageFetchComplete', true);
   } catch (err) {
     window.log.error(
       'storageService.sync: error processing manifest',
@@ -1013,7 +1023,7 @@ export async function eraseAllStorageServiceState(): Promise<void> {
   window.log.info('storageService.eraseAllStorageServiceState: complete');
 }
 
-export const storageServiceUploadJob = _.debounce(() => {
+export const storageServiceUploadJob = debounce(() => {
   if (!storageServiceEnabled) {
     window.log.info(
       'storageService.storageServiceUploadJob: called before enabled'
@@ -1024,7 +1034,7 @@ export const storageServiceUploadJob = _.debounce(() => {
   storageJobQueue(upload, `upload v${window.storage.get('manifestVersion')}`);
 }, 500);
 
-export const runStorageServiceSyncJob = _.debounce(() => {
+export const runStorageServiceSyncJob = debounce(() => {
   if (!storageServiceEnabled) {
     window.log.info(
       'storageService.runStorageServiceSyncJob: called before enabled'