eslintify all test files

test/views/network_status_view_test.js

@@ -1,149 +1,143 @@
-describe('NetworkStatusView', function() {
-  describe('getNetworkStatus', function() {
-    var networkStatusView;
-    var socketStatus = WebSocket.OPEN;
+/* global _, $, Whisper */
 
-    var oldGetSocketStatus;
+describe('NetworkStatusView', () => {
+  describe('getNetworkStatus', () => {
+    let networkStatusView;
+    let socketStatus = WebSocket.OPEN;
+
+    let oldGetSocketStatus;
 
     /* BEGIN stubbing globals */
-    before(function() {
+    before(() => {
       oldGetSocketStatus = window.getSocketStatus;
-      window.getSocketStatus = function() {
-        return socketStatus;
-      };
+      window.getSocketStatus = () => socketStatus;
     });
 
-    after(function() {
+    after(() => {
       window.getSocketStatus = oldGetSocketStatus;
 
       // It turns out that continued calls to window.getSocketStatus happen
       //   because we host NetworkStatusView in three mock interfaces, and the view
       //   checks every N seconds. That results in infinite errors unless there is
       //   something to call.
-      window.getSocketStatus = function() {
-        return WebSocket.OPEN;
-      };
+      window.getSocketStatus = () => WebSocket.OPEN;
     });
     /* END stubbing globals */
 
-    beforeEach(function() {
+    beforeEach(() => {
       networkStatusView = new Whisper.NetworkStatusView();
       $('.network-status-container').append(networkStatusView.el);
     });
-    afterEach(function() {
+    afterEach(() => {
       // prevents huge number of errors on console after running tests
       clearInterval(networkStatusView.renderIntervalHandle);
       networkStatusView = null;
     });
 
-    describe('initialization', function() {
-      it('should have an empty interval', function() {
+    describe('initialization', () => {
+      it('should have an empty interval', () => {
         assert.equal(
           networkStatusView.socketReconnectWaitDuration.asSeconds(),
           0
         );
       });
     });
-    describe('network status with no connection', function() {
-      beforeEach(function() {
-        networkStatusView.navigatorOnLine = function() {
-          return false;
-        };
+    describe('network status with no connection', () => {
+      beforeEach(() => {
+        networkStatusView.navigatorOnLine = () => false;
       });
-      it('should be interrupted', function() {
+      it('should be interrupted', () => {
         networkStatusView.update();
-        var status = networkStatusView.getNetworkStatus();
+        const status = networkStatusView.getNetworkStatus();
         assert(status.hasInterruption);
         assert.equal(status.instructions, 'Check your network connection.');
       });
-      it('should display an offline message', function() {
+      it('should display an offline message', () => {
         networkStatusView.update();
         assert.match(networkStatusView.$el.text(), /Offline/);
       });
-      it('should override socket status', function() {
+      it('should override socket status', () => {
         _([
           WebSocket.CONNECTING,
           WebSocket.OPEN,
           WebSocket.CLOSING,
           WebSocket.CLOSED,
-        ]).map(function(socketStatusVal) {
+        ]).forEach(socketStatusVal => {
           socketStatus = socketStatusVal;
           networkStatusView.update();
           assert.match(networkStatusView.$el.text(), /Offline/);
         });
       });
-      it('should override registration status', function() {
+      it('should override registration status', () => {
         Whisper.Registration.remove();
         networkStatusView.update();
         assert.match(networkStatusView.$el.text(), /Offline/);
       });
     });
-    describe('network status when registration is not done', function() {
-      beforeEach(function() {
+    describe('network status when registration is not done', () => {
+      beforeEach(() => {
         Whisper.Registration.remove();
       });
-      it('should display an unlinked message', function() {
+      it('should display an unlinked message', () => {
         networkStatusView.update();
         assert.match(networkStatusView.$el.text(), /Relink/);
       });
-      it('should override socket status', function() {
+      it('should override socket status', () => {
         _([
           WebSocket.CONNECTING,
           WebSocket.OPEN,
           WebSocket.CLOSING,
           WebSocket.CLOSED,
-        ]).map(function(socketStatusVal) {
+        ]).forEach(socketStatusVal => {
           socketStatus = socketStatusVal;
           networkStatusView.update();
           assert.match(networkStatusView.$el.text(), /Relink/);
         });
       });
     });
-    describe('network status when registration is done', function() {
-      beforeEach(function() {
-        networkStatusView.navigatorOnLine = function() {
-          return true;
-        };
+    describe('network status when registration is done', () => {
+      beforeEach(() => {
+        networkStatusView.navigatorOnLine = () => true;
         Whisper.Registration.markDone();
         networkStatusView.update();
       });
-      it('should not display an unlinked message', function() {
+      it('should not display an unlinked message', () => {
         networkStatusView.update();
         assert.notMatch(networkStatusView.$el.text(), /Relink/);
       });
     });
-    describe('network status when socket is connecting', function() {
-      beforeEach(function() {
+    describe('network status when socket is connecting', () => {
+      beforeEach(() => {
         Whisper.Registration.markDone();
         socketStatus = WebSocket.CONNECTING;
         networkStatusView.update();
       });
-      it('it should display a connecting string if connecting and not in the connecting grace period', function() {
+      it('it should display a connecting string if connecting and not in the connecting grace period', () => {
         networkStatusView.withinConnectingGracePeriod = false;
-        var status = networkStatusView.getNetworkStatus();
+        networkStatusView.getNetworkStatus();
 
         assert.match(networkStatusView.$el.text(), /Connecting/);
       });
-      it('it should not be interrupted if in connecting grace period', function() {
+      it('it should not be interrupted if in connecting grace period', () => {
         assert(networkStatusView.withinConnectingGracePeriod);
-        var status = networkStatusView.getNetworkStatus();
+        const status = networkStatusView.getNetworkStatus();
 
         assert.match(networkStatusView.$el.text(), /Connecting/);
         assert(!status.hasInterruption);
       });
-      it('it should be interrupted if connecting grace period is over', function() {
+      it('it should be interrupted if connecting grace period is over', () => {
         networkStatusView.withinConnectingGracePeriod = false;
-        var status = networkStatusView.getNetworkStatus();
+        const status = networkStatusView.getNetworkStatus();
 
         assert(status.hasInterruption);
       });
     });
-    describe('network status when socket is open', function() {
-      before(function() {
+    describe('network status when socket is open', () => {
+      before(() => {
         socketStatus = WebSocket.OPEN;
       });
-      it('should not be interrupted', function() {
-        var status = networkStatusView.getNetworkStatus();
+      it('should not be interrupted', () => {
+        const status = networkStatusView.getNetworkStatus();
         assert(!status.hasInterruption);
         assert.match(
           networkStatusView.$el
@@ -154,23 +148,23 @@ describe('NetworkStatusView', function() {
         );
       });
     });
-    describe('network status when socket is closed or closing', function() {
-      _([WebSocket.CLOSED, WebSocket.CLOSING]).map(function(socketStatusVal) {
-        it('should be interrupted', function() {
+    describe('network status when socket is closed or closing', () => {
+      _([WebSocket.CLOSED, WebSocket.CLOSING]).forEach(socketStatusVal => {
+        it('should be interrupted', () => {
           socketStatus = socketStatusVal;
           networkStatusView.update();
-          var status = networkStatusView.getNetworkStatus();
+          const status = networkStatusView.getNetworkStatus();
           assert(status.hasInterruption);
         });
       });
     });
-    describe('the socket reconnect interval', function() {
-      beforeEach(function() {
+    describe('the socket reconnect interval', () => {
+      beforeEach(() => {
         socketStatus = WebSocket.CLOSED;
         networkStatusView.setSocketReconnectInterval(61000);
         networkStatusView.update();
       });
-      it('should format the message based on the socketReconnectWaitDuration property', function() {
+      it('should format the message based on the socketReconnectWaitDuration property', () => {
         assert.equal(
           networkStatusView.socketReconnectWaitDuration.asSeconds(),
           61
@@ -180,7 +174,7 @@ describe('NetworkStatusView', function() {
           /Attempting reconnect/
         );
       });
-      it('should be reset by changing the socketStatus to CONNECTING', function() {});
+      it('should be reset by changing the socketStatus to CONNECTING', () => {});
     });
   });
 });