From dc8d8e529d883fb3eb5ea155c00dd0bbfda64522 Mon Sep 17 00:00:00 2001 From: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> Date: Tue, 7 Feb 2023 16:26:23 -0800 Subject: [PATCH] Disallow pinning broken conversations --- ts/models/conversations.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ts/models/conversations.ts b/ts/models/conversations.ts index 2369ee69ff..9f0ef684fa 100644 --- a/ts/models/conversations.ts +++ b/ts/models/conversations.ts @@ -5516,6 +5516,15 @@ export class ConversationModel extends window.Backbone return; } + const validationError = this.validate(); + if (validationError) { + log.error( + `not pinning ${this.idForLogging()} because of ` + + `validation error ${validationError}` + ); + return; + } + log.info('pinning', this.idForLogging()); const pinnedConversationIds = new Set( window.storage.get('pinnedConversationIds', new Array())