Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-20 02:08:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix typing indicators for 1:1 conversations

Browse Source 
Co-authored-by: trevor-signal <131492920+trevor-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2025-10-30 15:45:47 -05:00
committed by GitHub
parent b2f8f671ab
commit e421bcaf3d
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ts/background.preload.ts
View File

@@ -2186,7 +2186,7 @@ export async function startApp(): Promise<void> {
if (isGroup(conversation.attributes)) { if (isGroup(conversation.attributes)) {
// We drop typing notifications in groups we're not a part of // We drop typing notifications in groups we're not a part of
if (!conversation.areWeAMember()) { if (!conversation.areWeAGroupMember()) {
log.warn( log.warn(
`Received typing indicator for group ${conversation.idForLogging()}, which we're not a part of. Dropping.` `Received typing indicator for group ${conversation.idForLogging()}, which we're not a part of. Dropping.`
); );

2
ts/groups.preload.ts
View File

@@ -1992,7 +1992,7 @@ export async function isGroupEligibleToMigrate(
return false; return false;
} }
const areWeMember = conversation.areWeAMember(); const areWeMember = conversation.areWeAGroupMember();
if (!areWeMember) { if (!areWeMember) {
return false; return false;
} }

2
ts/messages/handleDataMessage.preload.ts
View File

@@ -327,7 +327,7 @@ export async function handleDataMessage(
return; return;
} }
const areWeMember = conversation.areWeAMember(); const areWeMember = conversation.areWeAGroupMember();
// Drop an incoming GroupV2 message if we or the sender are not part of the group // Drop an incoming GroupV2 message if we or the sender are not part of the group
// after applying the message's associated group changes. // after applying the message's associated group changes.

4
ts/models/conversations.preload.ts
View File

@@ -1411,7 +1411,7 @@ export class ConversationModel {
return; return;
} }
if (!this.areWeAMember()) { if (!isDirectConversation(this.attributes) && !this.areWeAGroupMember()) {
log.warn( log.warn(
`sendTypingMessage(${this.idForLogging()}): not sending, we are not a member` `sendTypingMessage(${this.idForLogging()}): not sending, we are not a member`
); );
@@ -5379,7 +5379,7 @@ export class ConversationModel {
return areWeAdmin(this.attributes); return areWeAdmin(this.attributes);
} }
areWeAMember(): boolean { areWeAGroupMember(): boolean {
return ( return (
!this.get('left') && this.hasMember(itemStorage.user.getCheckedAci()) !this.get('left') && this.hasMember(itemStorage.user.getCheckedAci())
); );