From ea4a8303e3267dadabbfa7cf1a8e590ea9bfdbee Mon Sep 17 00:00:00 2001 From: automated-signal <37887102+automated-signal@users.noreply.github.com> Date: Wed, 16 Oct 2024 16:57:25 -0500 Subject: [PATCH] Use uuidv7 in callDisposition Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> --- ts/util/callDisposition.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/ts/util/callDisposition.ts b/ts/util/callDisposition.ts index a80683ecff..2c5cf24635 100644 --- a/ts/util/callDisposition.ts +++ b/ts/util/callDisposition.ts @@ -11,13 +11,13 @@ import { callIdFromRingId, RingUpdate, } from '@signalapp/ringrtc'; -import { v4 as generateGuid } from 'uuid'; import { isEqual } from 'lodash'; import { strictAssert } from './assert'; import { DataReader, DataWriter } from '../sql/Client'; import { SignalService as Proto } from '../protobuf'; import { bytesToUuid, uuidToBytes } from './uuidToBytes'; import { missingCaseError } from './missingCaseError'; +import { generateMessageId } from './generateMessageId'; import { CallEndedReason, GroupCallJoinState } from '../types/Calling'; import { CallMode, @@ -1212,16 +1212,18 @@ async function saveCallHistory({ seenStatus = maxSeenStatus(seenStatus, prevMessage.seenStatus); } + const counter = + prevMessage?.received_at ?? receivedAtCounter ?? incrementMessageCounter(); + + const { id: newId } = generateMessageId(counter); + const message: MessageAttributesType = { - id: prevMessage?.id ?? generateGuid(), + id: prevMessage?.id ?? newId, conversationId: conversation.id, type: 'call-history', timestamp: prevMessage?.timestamp ?? callHistory.timestamp, sent_at: prevMessage?.sent_at ?? callHistory.timestamp, - received_at: - prevMessage?.received_at ?? - receivedAtCounter ?? - incrementMessageCounter(), + received_at: counter, received_at_ms: prevMessage?.received_at_ms ?? receivedAtMS ?? callHistory.timestamp, readStatus: ReadStatus.Read,