From eb34a8e0f1623486a56f9b46c11c508128db1a84 Mon Sep 17 00:00:00 2001 From: Daniel Zhang Date: Fri, 3 Mar 2023 09:56:59 -1000 Subject: [PATCH 1/4] Clarify directory for additional storage profiles --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d4eb51d0fc..c2fb3a458b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,7 +118,7 @@ empty application. But you can use the information from your production install Desktop to populate your testing application! First, exit both production and development apps (In macOS - literally quit the apps). -Second, find your application data: +Second, find your application data in the `userData` directory: - macOS: `~/Library/Application Support/Signal` - Linux: `~/.config/Signal` @@ -150,7 +150,7 @@ Once you have the additional numbers, you can setup additional storage profiles between them using the `NODE_APP_INSTANCE` environment variable. For example, to create an 'alice' profile, put a file called `local-alice.json` in the -`config` directory: +`config` directory for the `NODE_CONFIG_DIR` environment variable, not `userData` from above: ``` { From d1bd78d984aafb9f20a7b3f44f719aff20425961 Mon Sep 17 00:00:00 2001 From: Daniel Zhang Date: Fri, 3 Mar 2023 11:22:06 -1000 Subject: [PATCH 2/4] Fix electron documentation link --- CONTRIBUTING.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c2fb3a458b..4801a3faa8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,7 +118,7 @@ empty application. But you can use the information from your production install Desktop to populate your testing application! First, exit both production and development apps (In macOS - literally quit the apps). -Second, find your application data in the `userData` directory: +Second, find your application data in the [userData](https://www.electronjs.org/docs/latest/api/app#appgetpathname) directory: - macOS: `~/Library/Application Support/Signal` - Linux: `~/.config/Signal` @@ -164,8 +164,7 @@ Then you can start up the application a little differently to load the profile: NODE_APP_INSTANCE=alice yarn run start ``` -This changes the [userData](https://electron.atom.io/docs/all/#appgetpathname) -directory from `%appData%/Signal` to `%appData%/Signal-aliceProfile`. +This changes the `userData` directory from `%appData%/Signal` to `%appData%/Signal-aliceProfile`. # Making changes From 87a818e2fb7d5e8eb3b4dd30f9ddd88034f1de4b Mon Sep 17 00:00:00 2001 From: Daniel Zhang Date: Fri, 10 Mar 2023 13:48:12 -1000 Subject: [PATCH 3/4] Fix appData; Remove NODE_CONFIG_DIR --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4801a3faa8..64963e7c3c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -118,7 +118,7 @@ empty application. But you can use the information from your production install Desktop to populate your testing application! First, exit both production and development apps (In macOS - literally quit the apps). -Second, find your application data in the [userData](https://www.electronjs.org/docs/latest/api/app#appgetpathname) directory: +Second, find your application data in the [appData](https://www.electronjs.org/docs/latest/api/app#appgetpathname) directory: - macOS: `~/Library/Application Support/Signal` - Linux: `~/.config/Signal` @@ -150,7 +150,7 @@ Once you have the additional numbers, you can setup additional storage profiles between them using the `NODE_APP_INSTANCE` environment variable. For example, to create an 'alice' profile, put a file called `local-alice.json` in the -`config` directory for the `NODE_CONFIG_DIR` environment variable, not `userData` from above: +`config` directory, a child of the Signal directory, not `appData` from above: ``` { From 82c15026382498c852a5d38f80ade6fbb0d83d3c Mon Sep 17 00:00:00 2001 From: Daniel Zhang Date: Mon, 13 Mar 2023 09:16:18 -1000 Subject: [PATCH 4/4] Clarify config subdirectory --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 64963e7c3c..c6b2f6acf0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -150,7 +150,7 @@ Once you have the additional numbers, you can setup additional storage profiles between them using the `NODE_APP_INSTANCE` environment variable. For example, to create an 'alice' profile, put a file called `local-alice.json` in the -`config` directory, a child of the Signal directory, not `appData` from above: +`/config` subdirectory of your project checkout where you'll find other `.json` config files: ``` {