Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-05-08 08:58:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary props from <ContactName>

Browse Source
This commit is contained in:
Evan Hahn
2021-09-16 11:15:43 -05:00
committed by GitHub
parent 43685d15c6
commit eed7aff925
42 changed files with 57 additions and 423 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ts/components/conversationList/ContactCheckbox.tsx
+1 -7
View File
@@ -71,13 +71,7 @@ export const ContactCheckbox: FunctionComponent<PropsType> = React.memo(
const headerName = isMe ? (
i18n('noteToSelf')
) : (
<ContactName
phoneNumber={phoneNumber}
name={name}
profileName={profileName}
title={title}
i18n={i18n}
/>
<ContactName title={title} />
);
let messageText: ReactNode;
ts/components/conversationList/ContactListItem.tsx
+1 -7
View File
@@ -54,13 +54,7 @@ export const ContactListItem: FunctionComponent<PropsType> = React.memo(
const headerName = isMe ? (
i18n('noteToSelf')
) : (
<ContactName
phoneNumber={phoneNumber}
name={name}
profileName={profileName}
title={title}
i18n={i18n}
/>
<ContactName title={title} />
);
const messageText =
ts/components/conversationList/ConversationListItem.tsx
+1 -7
View File
@@ -91,13 +91,7 @@ export const ConversationListItem: FunctionComponent<Props> = React.memo(
const headerName = isMe ? (
i18n('noteToSelf')
) : (
<ContactName
phoneNumber={phoneNumber}
name={name}
profileName={profileName}
title={title}
i18n={i18n}
/>
<ContactName title={title} />
);
let messageText: ReactNode = null;
ts/components/conversationList/MessageSearchResult.tsx
+1 -14
View File
@@ -62,23 +62,10 @@ const renderPerson = (
i18n: LocalizerType,
person: Readonly<{
isMe?: boolean;
name?: string;
phoneNumber?: string;
profileName?: string;
title: string;
}>
): ReactNode =>
person.isMe ? (
i18n('you')
) : (
<ContactName
phoneNumber={person.phoneNumber}
name={person.name}
profileName={person.profileName}
title={person.title}
i18n={i18n}
/>
);
person.isMe ? i18n('you') : <ContactName title={person.title} />;
// This function exists because bodyRanges tells us the character position
// where the at-mention starts at according to the full body text. The snippet