Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2025-12-24 12:19:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Treat falsy values as valid for i18n placeholders & fix groups in common message

Browse Source
This commit is contained in:
Jamie Kyle
2023-01-03 15:48:54 -08:00
committed by GitHub
parent 476006af96
commit fdaaa531b3
3 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ts/util/setupI18n.ts
View File

@@ -145,13 +145,14 @@ export function setupI18n(
}
const placeholderName = match[1];
const value = substitutions[placeholderName];
if (!value) {
let value = substitutions[placeholderName];
if (value == null) {
log.error(
`i18n: Value not provided for placeholder ${placeholderName} in key '${key}'`
);
value = '';
}
builder += value || '';
builder += value;
lastTextIndex = FIND_REPLACEMENTS.lastIndex;
match = FIND_REPLACEMENTS.exec(message);