7c2fde4433
Add Signal.Workflow namespace
2018-03-26 16:49:21 -04:00
4a7cc22de3
🎨 Use window.requestIdleCallback
2018-03-26 16:49:21 -04:00
4651cbc2eb
Improve `Message.upgradeSchema preconditions
2018-03-26 16:49:21 -04:00
ca28f3030b
Add MessageMigration module
2018-03-26 16:49:21 -04:00
8e762797c0
Remove attachment validation
...
Turns out `fileName` is optional and maybe even `contentType`. We should revisit
this at a later point in time.
2018-03-26 16:49:21 -04:00
09ee2d4ea2
Switch to using requestIdleCallback
...
Example:
https://developer.mozilla.org/en-US/docs/Web/API/Background_Tasks_API#Example
2018-03-26 16:49:21 -04:00
d13668544d
Rename IdleListener to IdleDetector
2018-03-26 16:49:21 -04:00
3140e4d66d
Implement basic IdleListener
2018-03-26 16:49:21 -04:00
867f73b80a
Use double quotes for identifiers in error messages
2018-03-26 16:38:34 -04:00
70cdd2b350
Add stringToArrayBuffer utility
...
This way we can avoid an extra dependency.
2018-03-26 16:38:34 -04:00
2ad0fd7db6
Use Lodash omit instead of delete
2018-03-26 16:38:34 -04:00
279b3f81c7
Add Attachment.deleteData
2018-03-26 16:38:34 -04:00
9a540d6d18
Load attachment data before sending message
2018-03-26 16:38:34 -04:00
6355c54114
Return relative path from writeAttachmentData
...
This will make our app more robust to changes in location on the file system.
2018-03-26 16:38:34 -04:00
2cd3d5ac16
Add Message schema version 3
2018-03-26 16:38:34 -04:00
aa82a2a5fb
Add context to Message.upgradeSchema
...
Allows us to pass in Electron/Node.js specific functions. This allows better
unit testing in Mocha where we don’t have access to Electron APIs.
2018-03-26 16:38:34 -04:00
ebe2a769c9
Add Attachment.migrateDataToFileSystem
2018-03-26 16:38:34 -04:00
cea42bde7d
Encryption support for backup and restore
...
Also moved to the _ prefix in backup.js for all private methods exported
for testing.
2018-03-20 11:53:54 -07:00
6d8f4b7b6e
Backup: zipped messages.json, flat attachments dir
...
Backup creates, in a target directory:
- An attachments folder, with all attachments, each named for their
parent message's id - a GUID. If there is more than one attachment
in a given message, each attachment beyond the first will end with
'-N', zero-indexed.
- A file named messages.zip. It contains exactly what went to disk in
the original export code, but zipped up.
Export is now only 'light,' and in this new messages.zip format.
Import supports both the new format and the old format. If the target
directory has a messages.zip file, we'll treat it as the new format.
Next up: Encrypting attachments and the messages.zip!
2018-03-20 11:53:22 -07:00
153a22f46b
Exclude unnecessary data in export: profiles, replayable errors
2018-03-20 11:53:22 -07:00
c0c758d459
Backup: All exports are now 'light' exports
2018-03-20 11:53:21 -07:00
e583434366
Refactor: Move Backup under window.Signal
2018-03-20 11:53:19 -07:00
c88381efe3
Use async / await to improve readability
2018-03-19 19:27:59 -04:00
2642844c27
Rewrite migration 17 without idb
...
We ran into issues when doing async operations inside of an IndexedDB
`onupgradeneeded` handler. The errors were ‘The transaction is not active’ or
‘Transaction has finished’. The following documentation confirmed that
transactions are committed/terminated when control returns to the event loop:
Spec
- https://www.w3.org/TR/IndexedDB/#transaction-lifetime-concept
- https://www.w3.org/TR/IndexedDB/#upgrade-transaction-construct
Stack Overflow
- https://stackoverflow.com/a/11059085
- https://stackoverflow.com/a/27338944
Since the initial database migration is so critical, I decided to avoid `idb`
with promise support for IndexedDB for now, but will reconsider using it for
other tasks in the future to improve readability of IndexedDB code.
2018-03-19 19:27:59 -04:00
a619d48fac
Update schema version history
2018-03-19 19:27:59 -04:00
0e20e8e2ea
Use Errors.toLogFormat
2018-03-19 19:27:59 -04:00
a5edbf8328
Initialize schema as first step in upgradeSchema
2018-03-19 19:27:59 -04:00
5d927b73e6
Use while loop for IDB cursor iteration
...
Previously, I messily combined promises and callbacks because I thought we
were affected by the microtask issue:
https://github.com/gasi/idb#iteratecursor--iteratekeycursor
ESLint’s `more/no-then` encouraged me to revisit this and it works as expected.
2018-03-19 19:27:59 -04:00
182e6ffe10
Add version 17 migration
2018-03-19 19:27:59 -04:00
752c8f97e6
🎨 Format ternaries
2018-03-19 19:27:59 -04:00
8dfaa5619f
Prefix private functions with underscore
2018-03-19 19:27:59 -04:00
ed336d31d7
Move schema versioning from Attachment to Message
2018-03-19 19:27:59 -04:00
b9e9f5e19a
🎨 withInheritedSchemaVersion to inheritSchemaVersion
2018-03-19 19:27:59 -04:00
df693ade7c
Allow Attachment.fileName to be null
2018-03-19 19:27:59 -04:00
c27746b79e
Add Message.withInheritedSchemaVersion
2018-03-19 19:27:59 -04:00
e9e46464c2
Add SchemaVersion type
2018-03-19 19:27:59 -04:00
add4b11df3
Skip invalid attachments and make function sync
2018-03-19 19:27:59 -04:00
3dfc823716
Add Attachment.removeSchemaVersion
2018-03-19 19:27:59 -04:00
26c273618a
Refactor: db tasks to database.js, log delete to modules/logs.js
2018-03-14 14:42:15 -07:00
43b47fd349
Avoid ensure-error for privacy reasons
...
Example:
```
> node
> const nonError = {foo: 'i-am-private'};
undefined
// before
> util.inspect(nonError);
'{ foo: \'i-am-private\' }'
// after
> nonError.toString()
'[object Object]'
>
```
2018-03-08 16:23:51 -05:00
ea07915e6b
Escape special characters in file path
2018-03-08 16:23:51 -05:00
44b81f68dd
Remove privacy redaction from Errors.toLogFormat
2018-03-08 16:23:51 -05:00
49e0850fb2
Extract Privacy module
...
Centralizes how we redact sensitive information.
2018-03-08 16:23:51 -05:00
0e2f8a8a06
Extract Errors.redactSensitivePaths
2018-03-08 16:22:38 -05:00
3dffdc3f0b
Rename Errors to GlobalErrors for clarity
2018-03-08 16:22:38 -05:00
2575196617
Extract Errors.addGlobalHandler procedure
2018-03-08 16:22:38 -05:00
be3e4d86c2
Add Errors.toLogFormat
...
Allows errors to be formatted and sanitized for logging. Removes sensitive paths
such as the app root directory.
Ideally, this module would be called singular `Error` but that is already a
global name. Using `Errors` plural is similar to Java convention for utilities
such as `Arrays`, `Collections`, `Files`, etc. See:
https://stackoverflow.com/a/11673838
2018-03-08 16:22:38 -05:00
b049412bfd
Document workaround for got FormData bug
...
See: https://github.com/sindresorhus/got/pull/466
2018-03-08 16:21:27 -05:00
710701d0fc
Document why key comes first
2018-03-08 16:21:27 -05:00
52f7de6a10
Add debuglogs module
2018-03-08 16:21:27 -05:00
Daniel Gasienica
Scott Nonnenberg
Scott Nonnenberg
Daniel Gasienica