Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-04-20 07:28:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't report exceptions as part of traffic metrics.

Browse Source
This commit is contained in:
Jon Chambers
2020-08-27 12:52:27 -04:00
committed by Jon Chambers
parent 4188cc2949
commit 08dd493f98
2 changed files with 8 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
service/src/main/java/org/whispersystems/textsecuregcm/metrics/MetricsRequestEventListener.java
View File

@@ -18,12 +18,10 @@ import java.util.List;
*/
class MetricsRequestEventListener implements RequestEventListener {
static final String COUNTER_NAME = MetricRegistry.name(MetricsRequestEventListener.class, "request");
static final String PATH_TAG = "path";
static final String STATUS_CODE_TAG = "status";
static final String TRAFFIC_SOURCE_TAG = "trafficSource";
static final String EXCEPTION_TAG = "exception";
static final String COUNTER_NAME = MetricRegistry.name(MetricsRequestEventListener.class, "request");
static final String PATH_TAG = "path";
static final String STATUS_CODE_TAG = "status";
static final String TRAFFIC_SOURCE_TAG = "trafficSource";
private final TrafficSource trafficSource;
private final MeterRegistry meterRegistry;
@@ -50,14 +48,6 @@ class MetricsRequestEventListener implements RequestEventListener {
final List<String> userAgentValues = event.getContainerRequest().getRequestHeader("User-Agent");
tags.addAll(UserAgentTagUtil.getUserAgentTags(userAgentValues != null ? userAgentValues.stream().findFirst().orElse(null) : null));
if (event.getException() != null) {
if (event.getException() instanceof MappableException) {
tags.add(Tag.of(EXCEPTION_TAG, event.getException().getCause().getClass().getSimpleName()));
} else {
tags.add(Tag.of(EXCEPTION_TAG, event.getException().getClass().getSimpleName()));
}
}
meterRegistry.counter(COUNTER_NAME, tags).increment();
}
}