Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-04-19 17:48:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add new variants of call quality survey values and clarify optionality

Browse Source
This commit is contained in:
Jon Chambers
2025-11-06 12:23:52 -05:00
committed by GitHub
parent 9da643dd69
commit 298b0d8d28
4 changed files with 95 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
service/src/main/java/org/whispersystems/textsecuregcm/metrics/CallQualitySurveyManager.java
View File

@@ -53,7 +53,13 @@ public class CallQualitySurveyManager {
final CallQualitySurveyResponsePubSubMessage.Builder pubSubMessageBuilder =
CallQualitySurveyResponsePubSubMessage.newBuilder()
.setResponseId(UUID.randomUUID().toString())
.setSubmissionTimestamp(clock.millis() * 1000);
.setSubmissionTimestamp(clock.millis() * 1000)
.setUserSatisfied(submitCallQualitySurveyRequest.getUserSatisfied())
.setStartTimestamp(submitCallQualitySurveyRequest.getStartTimestamp())
.setEndTimestamp(submitCallQualitySurveyRequest.getEndTimestamp())
.setCallType(submitCallQualitySurveyRequest.getCallType())
.setSuccess(submitCallQualitySurveyRequest.getSuccess())
.setCallEndReason(submitCallQualitySurveyRequest.getCallEndReason());
try {
final UserAgent userAgent = UserAgentUtil.parseUserAgentString(userAgentString);
@@ -70,10 +76,6 @@ public class CallQualitySurveyManager {
asnInfoProviderSupplier.get().lookup(remoteAddress)
.ifPresent(asnInfo -> pubSubMessageBuilder.setAsnRegion(asnInfo.regionCode()));
if (submitCallQualitySurveyRequest.hasUserSatisfied()) {
pubSubMessageBuilder.setUserSatisfied(submitCallQualitySurveyRequest.getUserSatisfied());
}
pubSubMessageBuilder.addAllCallQualityIssues(submitCallQualitySurveyRequest.getCallQualityIssuesList());
if (submitCallQualitySurveyRequest.hasAdditionalIssuesDescription()) {
@@ -84,36 +86,28 @@ public class CallQualitySurveyManager {
pubSubMessageBuilder.setDebugLogUrl(submitCallQualitySurveyRequest.getDebugLogUrl());
}
if (submitCallQualitySurveyRequest.hasStartTimestamp()) {
pubSubMessageBuilder.setStartTimestamp(submitCallQualitySurveyRequest.getStartTimestamp());
if (submitCallQualitySurveyRequest.hasRttMedianConnection()) {
pubSubMessageBuilder.setRttMedianConnection(submitCallQualitySurveyRequest.getRttMedianConnection());
}
if (submitCallQualitySurveyRequest.hasEndTimestamp()) {
pubSubMessageBuilder.setEndTimestamp(submitCallQualitySurveyRequest.getEndTimestamp());
if (submitCallQualitySurveyRequest.hasRttMedianMedia()) {
pubSubMessageBuilder.setRttMedianMedia(submitCallQualitySurveyRequest.getRttMedianMedia());
}
if (submitCallQualitySurveyRequest.hasCallType()) {
pubSubMessageBuilder.setCallType(submitCallQualitySurveyRequest.getCallType());
if (submitCallQualitySurveyRequest.hasJitterMedianRecv()) {
pubSubMessageBuilder.setJitterMedianRecv(submitCallQualitySurveyRequest.getJitterMedianRecv());
}
if (submitCallQualitySurveyRequest.hasSuccess()) {
pubSubMessageBuilder.setSuccess(submitCallQualitySurveyRequest.getSuccess());
if (submitCallQualitySurveyRequest.hasJitterMedianSend()) {
pubSubMessageBuilder.setJitterMedianSend(submitCallQualitySurveyRequest.getJitterMedianSend());
}
if (submitCallQualitySurveyRequest.hasCallEndReason()) {
pubSubMessageBuilder.setCallEndReason(submitCallQualitySurveyRequest.getCallEndReason());
if (submitCallQualitySurveyRequest.hasPacketLossFractionRecv()) {
pubSubMessageBuilder.setPacketLossFractionRecv(submitCallQualitySurveyRequest.getPacketLossFractionRecv());
}
if (submitCallQualitySurveyRequest.hasRttMedian()) {
pubSubMessageBuilder.setRttMedian(submitCallQualitySurveyRequest.getRttMedian());
}
if (submitCallQualitySurveyRequest.hasJitterMedian()) {
pubSubMessageBuilder.setJitterMedian(submitCallQualitySurveyRequest.getJitterMedian());
}
if (submitCallQualitySurveyRequest.hasPacketLossFraction()) {
pubSubMessageBuilder.setPacketLossFraction(submitCallQualitySurveyRequest.getPacketLossFraction());
if (submitCallQualitySurveyRequest.hasPacketLossFractionSend()) {
pubSubMessageBuilder.setPacketLossFractionSend(submitCallQualitySurveyRequest.getPacketLossFractionSend());
}
if (submitCallQualitySurveyRequest.hasCallTelemetry()) {