diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java b/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java index f70fd97b6..6e290423b 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java @@ -125,7 +125,6 @@ public class RegistrationLockVerificationManager { final DistributionSummary registrationLockIdleDays = DistributionSummary .builder(name(RegistrationLockVerificationManager.class, "registrationLockIdleDays")) .tags(additionalTags) - .publishPercentiles(0.75, 0.95, 0.99, 0.999) .distributionStatisticExpiry(Duration.ofHours(2)) .register(Metrics.globalRegistry); diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java b/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java index b42f288d4..035df18e3 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java @@ -210,12 +210,10 @@ public class BackupManager { DistributionSummary.builder(NUM_OBJECTS_SUMMARY_NAME) .tags(tags) - .publishPercentileHistogram() .register(Metrics.globalRegistry) .record(storedBackupAttributes.numObjects()); DistributionSummary.builder(BYTES_USED_SUMMARY_NAME) .tags(tags) - .publishPercentileHistogram() .register(Metrics.globalRegistry) .record(storedBackupAttributes.bytesUsed()); } @@ -729,7 +727,6 @@ public class BackupManager { concurrentDeletes) .count() .doOnSuccess(itemsRemoved -> DistributionSummary.builder(DELETE_COUNT_DISTRIBUTION_NAME) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record(itemsRemoved)) .then() diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java index cd8774005..8316474dc 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java @@ -390,7 +390,6 @@ public class DeviceController { if (response != null && response.getStatus() == Response.Status.OK.getStatusCode()) { accountAndSample.second().stop(Timer.builder(WAIT_FOR_LINKED_DEVICE_TIMER_NAME) - .publishPercentileHistogram(true) .tags(Tags.of(UserAgentTagUtil.getPlatformTag(userAgent))) .register(Metrics.globalRegistry)); } @@ -602,7 +601,6 @@ public class DeviceController { .whenComplete((response, throwable) -> { if (response != null && response.getStatus() == Response.Status.OK.getStatusCode()) { accountAndSample.second().stop(Timer.builder(WAIT_FOR_TRANSFER_ARCHIVE_TIMER_NAME) - .publishPercentileHistogram(true) .tags(Tags.of( UserAgentTagUtil.getPlatformTag(userAgent), primaryPlatformTag(accountAndSample.first()))) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java index e8a4fc570..a9d43f5de 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java @@ -60,7 +60,6 @@ public class KeepAliveController { Timer.builder(CLOSED_CONNECTION_AGE_DISTRIBUTION_NAME) .tags(Tags.of(UserAgentTagUtil.getPlatformTag(context.getClient().getUserAgent()))) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record(age); } diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java index 4f92fb721..c8121abc5 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java @@ -147,12 +147,10 @@ public class MessageController { INDIVIDUAL_MESSAGE_LATENCY_TIMER = Timer.builder(timerName) .tags(multiRecipientTagName, "false") - .publishPercentileHistogram(true) .register(Metrics.globalRegistry); MULTI_RECIPIENT_MESSAGE_LATENCY_TIMER = Timer.builder(timerName) .tags(multiRecipientTagName, "true") - .publishPercentileHistogram(true) .register(Metrics.globalRegistry); } diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java index d52e06795..614ff5336 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java @@ -56,7 +56,6 @@ public class RegistrationController { private static final DistributionSummary REREGISTRATION_IDLE_DAYS_DISTRIBUTION = DistributionSummary .builder(name(RegistrationController.class, "reregistrationIdleDays")) - .publishPercentiles(0.75, 0.95, 0.99, 0.999) .distributionStatisticExpiry(Duration.ofHours(2)) .register(Metrics.globalRegistry); diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java index 88d463f95..0d4415a38 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java @@ -57,7 +57,6 @@ public class BackupMetrics { final boolean oversize, final Optional backupLength) { DistributionSummary.builder(MESSAGE_BACKUP_SIZE_NAME) - .publishPercentileHistogram(true) .tags(Tags.of( UserAgentTagUtil.getPlatformTag(authenticatedBackupUser.userAgent()), Tag.of("tier", authenticatedBackupUser.backupLevel().name().toLowerCase()), diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java index eba8a611f..59d1d3e0e 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java @@ -86,7 +86,6 @@ public final class MessageMetrics { UserAgentTagUtil.getClientVersionTag(userAgent, clientReleaseManager).ifPresent(tags::add); Timer.builder(DELIVERY_LATENCY_TIMER_NAME) - .publishPercentileHistogram(true) .tags(tags) .register(metricRegistry) .record(Duration.between(Instant.ofEpochMilli(serverTimestamp), Instant.now())); diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java index 314b00deb..08024f1a9 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java @@ -149,7 +149,6 @@ public class MicrometerAwsSdkMetricPublisher implements MetricPublisher { DistributionSummary.builder(API_CALL_RETRY_COUNT_DISTRIBUTION_NAME) .tags(tags) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record(retryCount); @@ -179,21 +178,18 @@ public class MicrometerAwsSdkMetricPublisher implements MetricPublisher { Optional.ofNullable(httpMetricsByName.get("ConcurrencyAcquireDuration")) .ifPresent(channelAcquisitionDurationMetricRecord -> Timer.builder(CHANNEL_ACQUISITION_TIMER_NAME) .tags(attemptTags) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record((Duration) channelAcquisitionDurationMetricRecord.value())); Optional.ofNullable(httpMetricsByName.get("LeasedConcurrency")) .ifPresent(concurrentRequestsMetricRecord -> DistributionSummary.builder(CONCURRENT_REQUESTS_DISTRIBUTION_NAME) .tags(attemptTags) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record((int) concurrentRequestsMetricRecord.value())); Optional.ofNullable(httpMetricsByName.get("PendingConcurrencyAcquires")) .ifPresent(pendingChannelAcquisitionsMetricRecord -> DistributionSummary.builder(PENDING_CHANNEL_ACQUISITIONS_DISTRIBUTION_NAME) .tags(attemptTags) - .publishPercentileHistogram(true) .register(Metrics.globalRegistry) .record((int) pendingChannelAcquisitionsMetricRecord.value())); }); diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java index 019ba31df..a545ed788 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java @@ -85,7 +85,6 @@ public class OpenWebSocketCounter { context.addWebsocketClosedListener((_, statusCode, _) -> { sample.stop(Timer.builder(durationTimerName) - .publishPercentileHistogram(true) .tags(tagsWithClientPlatform) .register(Metrics.globalRegistry)); diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java b/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java index b18b08f35..29e33b0ce 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java @@ -36,7 +36,6 @@ public class MultiRecipientMessageProvider implements MessageBodyReader sample.stop(Timer.builder(SEND_MESSAGE_DURATION_TIMER_NAME) - .publishPercentileHistogram(true) .tags(platformTag) .register(Metrics.globalRegistry))); }