Don't explicitly notify clients when messages get persisted.

This commit is contained in:
Jon Chambers
2020-09-09 19:25:25 -04:00
committed by Jon Chambers
parent 7e14a0bc30
commit 66a04ed730
3 changed files with 7 additions and 56 deletions

View File

@@ -6,7 +6,6 @@ import org.apache.commons.lang3.RandomStringUtils;
import org.junit.Before;
import org.junit.Test;
import org.whispersystems.textsecuregcm.entities.MessageProtos;
import org.whispersystems.textsecuregcm.push.PushSender;
import org.whispersystems.textsecuregcm.redis.AbstractRedisClusterTest;
import java.nio.charset.StandardCharsets;
@@ -31,12 +30,11 @@ import static org.mockito.Mockito.when;
public class MessagePersisterTest extends AbstractRedisClusterTest {
private ExecutorService notificationExecutorService;
private MessagesCache messagesCache;
private Messages messagesDatabase;
private PubSubManager pubSubManager;
private ExecutorService notificationExecutorService;
private MessagesCache messagesCache;
private Messages messagesDatabase;
private MessagePersister messagePersister;
private AccountsManager accountsManager;
private AccountsManager accountsManager;
private static final UUID DESTINATION_ACCOUNT_UUID = UUID.randomUUID();
private static final String DESTINATION_ACCOUNT_NUMBER = "+18005551234";
@@ -55,7 +53,6 @@ public class MessagePersisterTest extends AbstractRedisClusterTest {
messagesDatabase = mock(Messages.class);
accountsManager = mock(AccountsManager.class);
pubSubManager = mock(PubSubManager.class);
final Account account = mock(Account.class);
@@ -64,7 +61,7 @@ public class MessagePersisterTest extends AbstractRedisClusterTest {
notificationExecutorService = Executors.newSingleThreadExecutor();
messagesCache = new MessagesCache(getRedisCluster(), notificationExecutorService);
messagePersister = new MessagePersister(messagesCache, messagesManager, pubSubManager, mock(PushSender.class), accountsManager, PERSIST_DELAY);
messagePersister = new MessagePersister(messagesCache, messagesManager, accountsManager, PERSIST_DELAY);
doAnswer(invocation -> {
final String destination = invocation.getArgument(0, String.class);
@@ -148,7 +145,6 @@ public class MessagePersisterTest extends AbstractRedisClusterTest {
messagePersister.persistNextQueues(now.plus(messagePersister.getPersistDelay()));
verify(pubSubManager, times(queueCount)).publish(any(), any());
verify(messagesDatabase, times(queueCount * messagesPerQueue)).store(any(UUID.class), any(MessageProtos.Envelope.class), anyString(), anyLong());
}