From 7bb4a4bc904edcddb316a986e99fba3e6e85776c Mon Sep 17 00:00:00 2001 From: Jon Chambers Date: Fri, 1 Aug 2025 18:17:24 -0400 Subject: [PATCH] Remove an unused `hasMessages` method --- .../textsecuregcm/storage/MessagesCache.java | 5 ----- .../textsecuregcm/storage/MessagesCacheTest.java | 11 ----------- 2 files changed, 16 deletions(-) diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java b/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java index 111366dbd..a3b9ed777 100644 --- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java +++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java @@ -285,11 +285,6 @@ public class MessagesCache { } - public boolean hasMessages(final UUID destinationUuid, final byte destinationDevice) { - return redisCluster.withBinaryCluster( - connection -> connection.sync().zcard(getMessageQueueKey(destinationUuid, destinationDevice)) > 0); - } - public CompletableFuture hasMessagesAsync(final UUID destinationUuid, final byte destinationDevice) { return redisCluster.withBinaryCluster(connection -> connection.async().zcard(getMessageQueueKey(destinationUuid, destinationDevice)) diff --git a/service/src/test/java/org/whispersystems/textsecuregcm/storage/MessagesCacheTest.java b/service/src/test/java/org/whispersystems/textsecuregcm/storage/MessagesCacheTest.java index 02fbdbd35..fcb93a2bb 100644 --- a/service/src/test/java/org/whispersystems/textsecuregcm/storage/MessagesCacheTest.java +++ b/service/src/test/java/org/whispersystems/textsecuregcm/storage/MessagesCacheTest.java @@ -193,17 +193,6 @@ class MessagesCacheTest { assertEquals(messagesToPreserve, get(DESTINATION_UUID, DESTINATION_DEVICE_ID, messageCount)); } - @Test - void testHasMessages() { - assertFalse(messagesCache.hasMessages(DESTINATION_UUID, DESTINATION_DEVICE_ID)); - - final UUID messageGuid = UUID.randomUUID(); - final MessageProtos.Envelope message = generateRandomMessage(messageGuid, true); - messagesCache.insert(messageGuid, DESTINATION_UUID, DESTINATION_DEVICE_ID, message).join(); - - assertTrue(messagesCache.hasMessages(DESTINATION_UUID, DESTINATION_DEVICE_ID)); - } - @Test void testHasMessagesAsync() { assertFalse(messagesCache.hasMessagesAsync(DESTINATION_UUID, DESTINATION_DEVICE_ID).join());