Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-04-20 18:18:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix oneof field validation

Browse Source
This commit is contained in:
Ravi Khadiwala
2026-03-03 12:08:10 -06:00
committed by ravi-signal
parent f5f217f3de
commit a90fa5db02
5 changed files with 43 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
service/src/test/java/org/whispersystems/textsecuregcm/grpc/ValidatingInterceptorTest.java
View File

@@ -5,6 +5,7 @@
package org.whispersystems.textsecuregcm.grpc;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import com.google.protobuf.ByteString;
@@ -406,6 +407,22 @@ public class ValidatingInterceptorTest {
stub.validationsEndpoint(builderWithValidDefaults().setRecursiveMessage(recursiveMessage).build()));
}
@Test
public void oneOfValidation() throws Exception {
// These should pass even if we don't meet the requirements on the one-of case that we're not setting
assertDoesNotThrow(() ->
stub.validationsEndpoint(builderWithValidDefaults()
.setOneOfNonEmptyBytes(ByteString.copyFrom(new byte[1]))
.build()));
assertDoesNotThrow(() ->
stub.validationsEndpoint(builderWithValidDefaults()
.setOneOfMessage(ValidationsRequest.RequirePresentMessage.getDefaultInstance())
.build()));
assertStatusException(Status.INVALID_ARGUMENT, () -> stub.validationsEndpoint(ValidationsRequest.newBuilder().setOneOfNonEmptyBytes(ByteString.EMPTY).build()));
}
@Nonnull
private static ValidationsRequest.Builder builderWithValidDefaults() {
return ValidationsRequest.newBuilder()