Decompose CurrencyConversion update methods

This commit is contained in:
Chris Eager
2025-10-06 10:15:01 -05:00
committed by Chris Eager
parent e9d6b91416
commit ab1ec86cd2
2 changed files with 43 additions and 33 deletions

View File

@@ -50,7 +50,7 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, coinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, Clock.systemUTC());
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();
@@ -79,7 +79,7 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, CoinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, Clock.systemUTC());
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();
@@ -108,7 +108,7 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, CoinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, Clock.systemUTC());
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();
@@ -137,11 +137,11 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, CoinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, Clock.systemUTC());
manager.updateCacheIfNecessary();
manager.update();
when(CoinGeckoClient.getSpotPrice(eq("FOO"), eq("USD"))).thenReturn(new BigDecimal("3.50"));
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();
@@ -169,13 +169,13 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, CoinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, Clock.systemUTC());
manager.updateCacheIfNecessary();
manager.update();
REDIS_CLUSTER_EXTENSION.getRedisCluster().useCluster(connection ->
connection.sync().del(CurrencyConversionManager.COIN_GECKO_CAP_SHARED_CACHE_CURRENT_KEY));
connection.sync().del(CurrencyConversionManager.COIN_GECKO_SHARED_CACHE_CURRENT_KEY));
when(CoinGeckoClient.getSpotPrice(eq("FOO"), eq("USD"))).thenReturn(new BigDecimal("3.50"));
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();
@@ -210,7 +210,7 @@ class CurrencyConversionManagerTest {
CurrencyConversionManager manager = new CurrencyConversionManager(fixerClient, CoinGeckoClient, REDIS_CLUSTER_EXTENSION.getRedisCluster(),
List.of("FOO"), EXECUTOR, clock);
manager.updateCacheIfNecessary();
manager.update();
when(CoinGeckoClient.getSpotPrice(eq("FOO"), eq("USD"))).thenReturn(new BigDecimal("3.50"));
when(fixerClient.getConversionsForBase(eq("USD"))).thenReturn(Map.of(
@@ -223,7 +223,7 @@ class CurrencyConversionManagerTest {
when(clock.instant()).thenReturn(afterFixerExpiration);
when(clock.millis()).thenReturn(afterFixerExpiration.toEpochMilli());
manager.updateCacheIfNecessary();
manager.update();
CurrencyConversionEntityList conversions = manager.getCurrencyConversions().orElseThrow();