Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-04-21 15:48:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove unnecessary MessageMetrics default constructor

Browse Source
This commit is contained in:
Jonathan Klabunde Tomer
2025-08-11 12:28:28 -07:00
committed by GitHub
parent 36d0c4422e
commit dabe1c157b
5 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
service/src/test/java/org/whispersystems/textsecuregcm/controllers/MessageControllerTest.java
View File

@@ -195,7 +195,7 @@ class MessageControllerTest {
new MessageController(rateLimiters, cardinalityEstimator, messageSender, receiptSender, accountsManager,
messagesManager, phoneNumberIdentifiers, pushNotificationManager, pushNotificationScheduler,
reportMessageManager, messageDeliveryScheduler, mock(ClientReleaseManager.class),
serverSecretParams, SpamChecker.noop(), new MessageMetrics(), mock(MessageDeliveryLoopMonitor.class),
serverSecretParams, SpamChecker.noop(), new MessageMetrics(Duration.ofDays(30)), mock(MessageDeliveryLoopMonitor.class),
clock))
.build();

2
service/src/test/java/org/whispersystems/textsecuregcm/metrics/MetricsUtilTest.java
View File

@@ -99,7 +99,7 @@ class MetricsUtilTest {
final OpenTelemetryConfiguration openTelemetryConfig =
new OpenTelemetryConfiguration(true, Duration.ZERO, 8, Map.of(), Map.of());
// Yes, this has to be OtlpMeterRegistry—its histograms behave differently than SimpleMeterRegistry's 😭
// Yes, this has to be OtlpMeterRegistry—its histograms behave differently than SimpleMeterRegistry's
final MeterRegistry registry = new OtlpMeterRegistry(openTelemetryConfig, Clock.SYSTEM);
MetricsUtil.configureHistogramFilters(registry.config(), openTelemetryConfig);

4
service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionIntegrationTest.java
View File

@@ -134,7 +134,7 @@ class WebSocketConnectionIntegrationTest {
final WebSocketConnection webSocketConnection = new WebSocketConnection(
mock(ReceiptSender.class),
new MessagesManager(messagesDynamoDb, messagesCache, redisMessageAvailabilityManager, reportMessageManager, sharedExecutorService, Clock.systemUTC()),
new MessageMetrics(),
new MessageMetrics(Duration.ofDays(30)),
mock(PushNotificationManager.class),
mock(PushNotificationScheduler.class),
account,
@@ -223,7 +223,7 @@ class WebSocketConnectionIntegrationTest {
final WebSocketConnection webSocketConnection = new WebSocketConnection(
mock(ReceiptSender.class),
new MessagesManager(messagesDynamoDb, messagesCache, redisMessageAvailabilityManager, reportMessageManager, sharedExecutorService, Clock.systemUTC()),
new MessageMetrics(),
new MessageMetrics(Duration.ofDays(30)),
mock(PushNotificationManager.class),
mock(PushNotificationScheduler.class),
account,

4
service/src/test/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnectionTest.java
View File

@@ -119,7 +119,7 @@ class WebSocketConnectionTest {
WebSocketAccountAuthenticator webSocketAuthenticator =
new WebSocketAccountAuthenticator(accountAuthenticator);
AuthenticatedConnectListener connectListener = new AuthenticatedConnectListener(accountsManager, receiptSender, messagesManager,
new MessageMetrics(), mock(PushNotificationManager.class), mock(PushNotificationScheduler.class),
new MessageMetrics(Duration.ofDays(30)), mock(PushNotificationManager.class), mock(PushNotificationScheduler.class),
mock(RedisMessageAvailabilityManager.class), mock(DisconnectionRequestManager.class),
messageDeliveryScheduler, clientReleaseManager, mock(MessageDeliveryLoopMonitor.class),
mock(ExperimentEnrollmentManager.class));
@@ -625,7 +625,7 @@ class WebSocketConnectionTest {
private WebSocketConnection webSocketConnection(final WebSocketClient client) {
return new WebSocketConnection(receiptSender,
messagesManager,
new MessageMetrics(),
new MessageMetrics(Duration.ofDays(30)),
mock(PushNotificationManager.class),
mock(PushNotificationScheduler.class),
account,