Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-04-21 14:58:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add validation annotations to DynamicExperimentEnrollmentConfiguration

Browse Source
This commit is contained in:
Chris Eager
2024-05-23 13:28:34 -05:00
committed by Jon Chambers
parent 9ec4f0b2f5
commit f6d1e566e7
2 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
service/src/test/java/org/whispersystems/textsecuregcm/configuration/dynamic/DynamicConfigurationTest.java
View File

@@ -44,6 +44,22 @@ class DynamicConfigurationTest {
assertFalse(emptyConfig.getExperimentEnrollmentConfiguration("test").isPresent());
}
{
final String invalid = REQUIRED_CONFIG.concat("""
experiments:
percentageOnly:
enrollmentPercentage: 12
uuidsAndPercentage:
uuidSelector:
# the below results in uuids = null
uuids:
""");
final Optional<DynamicConfiguration> maybeConfig =
DynamicConfigurationManager.parseConfiguration(invalid, DynamicConfiguration.class);
assertFalse(maybeConfig.isPresent());
}
{
final String experimentConfigYaml = REQUIRED_CONFIG.concat("""
experiments: