Remove groups v2 capability

* wip removing groups v2 capabilities

* comments

* finish removing groups v2 references

* hardcode gv1migration flag on user capability, remove other references

service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java

@@ -188,7 +188,7 @@ public class DeviceController {
     }
 
     final DeviceCapabilities capabilities = accountAttributes.getCapabilities();
-    if (capabilities != null && isCapabilityDowngrade(account.get(), capabilities, userAgent)) {
+    if (capabilities != null && isCapabilityDowngrade(account.get(), capabilities)) {
       throw new WebApplicationException(Response.status(409).build());
     }
 
@@ -236,7 +236,7 @@ public class DeviceController {
     return new VerificationCode(randomInt);
   }
 
-  private boolean isCapabilityDowngrade(Account account, DeviceCapabilities capabilities, String userAgent) {
+  private boolean isCapabilityDowngrade(Account account, DeviceCapabilities capabilities) {
     boolean isDowngrade = false;
 
     isDowngrade |= account.isStoriesSupported() && !capabilities.isStories();
@@ -244,35 +244,8 @@ public class DeviceController {
     isDowngrade |= account.isChangeNumberSupported() && !capabilities.isChangeNumber();
     isDowngrade |= account.isAnnouncementGroupSupported() && !capabilities.isAnnouncementGroup();
     isDowngrade |= account.isSenderKeySupported() && !capabilities.isSenderKey();
-    isDowngrade |= account.isGv1MigrationSupported() && !capabilities.isGv1Migration();
     isDowngrade |= account.isGiftBadgesSupported() && !capabilities.isGiftBadges();
 
-    if (account.isGroupsV2Supported()) {
-      try {
-        switch (UserAgentUtil.parseUserAgentString(userAgent).getPlatform()) {
-          case DESKTOP:
-          case ANDROID: {
-            if (!capabilities.isGv2_3()) {
-              isDowngrade = true;
-            }
-
-            break;
-          }
-
-          case IOS: {
-            if (!capabilities.isGv2_2() && !capabilities.isGv2_3()) {
-              isDowngrade = true;
-            }
-
-            break;
-          }
-        }
-      } catch (final UnrecognizedUserAgentException e) {
-        // If we can't parse the UA string, the client is for sure too old to support groups V2
-        isDowngrade = true;
-      }
-    }
-
     return isDowngrade;
   }
 }

service/src/main/java/org/whispersystems/textsecuregcm/entities/UserCapabilities.java

@@ -12,8 +12,7 @@ public class UserCapabilities {
 
   public static UserCapabilities createForAccount(Account account) {
     return new UserCapabilities(
-        account.isGroupsV2Supported(),
-        account.isGv1MigrationSupported(),
+        true,
         account.isSenderKeySupported(),
         account.isAnnouncementGroupSupported(),
         account.isChangeNumberSupported(),
@@ -21,9 +20,6 @@ public class UserCapabilities {
         account.isGiftBadgesSupported());
   }
 
-  @JsonProperty
-  private boolean gv2;
-
   @JsonProperty("gv1-migration")
   private boolean gv1Migration;
 
@@ -45,7 +41,7 @@ public class UserCapabilities {
   public UserCapabilities() {
   }
 
-  public UserCapabilities(final boolean gv2,
+  public UserCapabilities(
       boolean gv1Migration,
       final boolean senderKey,
       final boolean announcementGroup,
@@ -53,7 +49,6 @@ public class UserCapabilities {
       final boolean stories,
       final boolean giftBadges) {
 
-    this.gv2 = gv2;
     this.gv1Migration = gv1Migration;
     this.senderKey = senderKey;
     this.announcementGroup = announcementGroup;
@@ -62,10 +57,6 @@ public class UserCapabilities {
     this.giftBadges = giftBadges;
   }
 
-  public boolean isGv2() {
-    return gv2;
-  }
-
   public boolean isGv1Migration() {
     return gv1Migration;
   }

service/src/main/java/org/whispersystems/textsecuregcm/storage/Account.java

@@ -181,14 +181,6 @@ public class Account {
     return devices.stream().filter(device -> device.getId() == deviceId).findFirst();
   }
 
-  public boolean isGroupsV2Supported() {
-    requireNotStale();
-
-    return devices.stream()
-                  .filter(Device::isEnabled)
-                  .allMatch(Device::isGroupsV2Supported);
-  }
-
   public boolean isStorageSupported() {
     requireNotStale();
 
@@ -201,10 +193,6 @@ public class Account {
     return getMasterDevice().map(Device::getCapabilities).map(Device.DeviceCapabilities::isTransfer).orElse(false);
   }
 
-  public boolean isGv1MigrationSupported() {
-    return allEnabledDevicesHaveCapability(DeviceCapabilities::isGv1Migration);
-  }
-
   public boolean isSenderKeySupported() {
     return allEnabledDevicesHaveCapability(DeviceCapabilities::isSenderKey);
   }

service/src/main/java/org/whispersystems/textsecuregcm/storage/Device.java

@@ -252,39 +252,13 @@ public class Device {
     return this.userAgent;
   }
 
-  public boolean isGroupsV2Supported() {
-    final boolean groupsV2Supported;
-
-    if (this.capabilities != null) {
-      final boolean ios = this.apnId != null || this.voipApnId != null;
-
-      groupsV2Supported = this.capabilities.isGv2_3() || (ios && this.capabilities.isGv2_2());
-    } else {
-      groupsV2Supported = false;
-    }
-
-    return groupsV2Supported;
-  }
-
   public static class DeviceCapabilities {
-    @JsonProperty
-    private boolean gv2;
-
-    @JsonProperty("gv2-2")
-    private boolean gv2_2;
-
-    @JsonProperty("gv2-3")
-    private boolean gv2_3;
-
     @JsonProperty
     private boolean storage;
 
     @JsonProperty
     private boolean transfer;
 
-    @JsonProperty("gv1-migration")
-    private boolean gv1Migration;
-
     @JsonProperty
     private boolean senderKey;
 
@@ -306,15 +280,11 @@ public class Device {
     public DeviceCapabilities() {
     }
 
-    public DeviceCapabilities(boolean gv2, final boolean gv2_2, final boolean gv2_3, boolean storage, boolean transfer,
-        boolean gv1Migration, final boolean senderKey, final boolean announcementGroup, final boolean changeNumber,
+    public DeviceCapabilities(boolean storage, boolean transfer,
+        final boolean senderKey, final boolean announcementGroup, final boolean changeNumber,
         final boolean pni, final boolean stories, final boolean giftBadges) {
-      this.gv2 = gv2;
-      this.gv2_2 = gv2_2;
-      this.gv2_3 = gv2_3;
       this.storage = storage;
       this.transfer = transfer;
-      this.gv1Migration = gv1Migration;
       this.senderKey = senderKey;
       this.announcementGroup = announcementGroup;
       this.changeNumber = changeNumber;
@@ -323,18 +293,6 @@ public class Device {
       this.giftBadges = giftBadges;
     }
 
-    public boolean isGv2() {
-      return gv2;
-    }
-
-    public boolean isGv2_2() {
-      return gv2_2;
-    }
-
-    public boolean isGv2_3() {
-      return gv2_3;
-    }
-
     public boolean isStorage() {
       return storage;
     }
@@ -343,10 +301,6 @@ public class Device {
       return transfer;
     }
 
-    public boolean isGv1Migration() {
-      return gv1Migration;
-    }
-
     public boolean isSenderKey() {
       return senderKey;
     }