Implemented ternary expression to make this if-else more concise.

This commit is contained in:
Ross Healy
2024-02-04 00:10:44 +00:00
parent 2f089a5a58
commit 7b350a8c01

View File

@@ -46,24 +46,16 @@ namespace lottery_co_uk_scraper
var ballsDrawn = doc.DocumentNode.Descendants("span") var ballsDrawn = doc.DocumentNode.Descendants("span")
.FirstOrDefault(x => x.Attributes["id"] != null && x.Attributes["id"].Value == "ballsDrawn"); .FirstOrDefault(x => x.Attributes["id"] != null && x.Attributes["id"].Value == "ballsDrawn");
List<int>? lottoBalls = null; List<int>? lottoBalls = (ballsDrawn != null)
List<int>? lottoBonusBalls = null; ? ExtractBalls(ballsDrawn, "lotto-ball")
: null;
if (ballsDrawn != null) List<int>? lottoBonusBalls = (ballsDrawn != null)
{ ? ExtractBalls(ballsDrawn, "lotto-bonus-ball")
lottoBalls = ExtractBalls(ballsDrawn, "lotto-ball"); : null;
lottoBonusBalls = ExtractBalls(ballsDrawn, "lotto-bonus-ball");
}
if (lottoBalls != null) PrintResults("Numbers inside lotto ball result", lottoBalls);
{ PrintResults("Numbers inside lotto bonus ball result", lottoBonusBalls);
Console.WriteLine("Numbers inside lotto ball result: " + string.Join(", ", lottoBalls));
}
if (lottoBonusBalls != null)
{
Console.WriteLine("Numbers inside lotto bonus ball result: " + string.Join(", ", lottoBonusBalls));
}
var ballSetUsed = doc.DocumentNode.Descendants("td") var ballSetUsed = doc.DocumentNode.Descendants("td")
.Where(x => x.InnerHtml.Contains("<strong>Ball Set Used:</strong>")) .Where(x => x.InnerHtml.Contains("<strong>Ball Set Used:</strong>"))
@@ -91,6 +83,7 @@ namespace lottery_co_uk_scraper
} }
Console.WriteLine($"Failed to parse {className} value: {x.InnerText}"); Console.WriteLine($"Failed to parse {className} value: {x.InnerText}");
return 0; return 0;
}) })
.ToList(); .ToList();
@@ -236,5 +229,13 @@ namespace lottery_co_uk_scraper
Console.WriteLine("Rolldown: " + rolldown); Console.WriteLine("Rolldown: " + rolldown);
} }
} }
private static void PrintResults(string label, List<int>? values)
{
if (values != null)
{
Console.WriteLine($"{label}: " + string.Join(", ", values));
}
}
} }
} }