Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: lint header files with clang-tidy (#7527)

Browse Source 
* build: clang-tidy headers when building libtransmission

* chore: revert `= default` workaround

It was introduced in 6909ec0bad to fix build issues with macOS 10.14. We
no longer support that version.

* fix: clang-tidy warnings for libtransmission

* build: clang-tidy headers when building tests

* fix: clang-tidy warnings for tests

* build: clang-tidy headers when building qt

* code review: don't manually edit mime-types.h

* code review: unify variable naming for static private members
This commit is contained in:
Yat Ho
2025-05-08 05:10:16 +08:00
committed by GitHub
parent f0c8fd689a
commit 08ec7fb7c7
78 changed files with 368 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libtransmission/crypto-utils.h
View File

@@ -174,7 +174,7 @@ using tr_sha1_string = tr_strbuf<char, sizeof(tr_sha1_digest_t) * 2U + 1U>;
/**
* @brief Generate an ascii hex string for a sha1 digest.
*/
[[nodiscard]] tr_sha1_string tr_sha1_to_string(tr_sha1_digest_t const&);
[[nodiscard]] tr_sha1_string tr_sha1_to_string(tr_sha1_digest_t const& digest);
/**
* @brief Generate a sha1 digest from a hex string.
@@ -186,7 +186,7 @@ using tr_sha256_string = tr_strbuf<char, sizeof(tr_sha256_digest_t) * 2U + 1U>;
/**
* @brief Generate an ascii hex string for a sha256 digest.
*/
[[nodiscard]] tr_sha256_string tr_sha256_to_string(tr_sha256_digest_t const&);
[[nodiscard]] tr_sha256_string tr_sha256_to_string(tr_sha256_digest_t const& digest);
/**
* @brief Generate a sha256 digest from a hex string.
@@ -196,7 +196,7 @@ using tr_sha256_string = tr_strbuf<char, sizeof(tr_sha256_digest_t) * 2U + 1U>;
// Convenience utility to efficiently get many random small values.
// Use this instead of making a lot of calls to tr_rand_int().
template<typename T = uint8_t, size_t N = 1024U>
class tr_salt_shaker
class tr_salt_shaker // NOLINT(cppcoreguidelines-pro-type-member-init): buf doesn't need to be initialised
{
public:
[[nodiscard]] auto operator()() noexcept