Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-25 04:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: lint header files with clang-tidy (#7527)

Browse Source 
* build: clang-tidy headers when building libtransmission

* chore: revert `= default` workaround

It was introduced in 6909ec0bad to fix build issues with macOS 10.14. We
no longer support that version.

* fix: clang-tidy warnings for libtransmission

* build: clang-tidy headers when building tests

* fix: clang-tidy warnings for tests

* build: clang-tidy headers when building qt

* code review: don't manually edit mime-types.h

* code review: unify variable naming for static private members
This commit is contained in:
Yat Ho
2025-05-08 05:10:16 +08:00
committed by GitHub
parent f0c8fd689a
commit 08ec7fb7c7
78 changed files with 368 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libtransmission/log.cc
View File

@@ -50,7 +50,7 @@ public:
tr_log_message** queue_tail_ = &queue_;
int queue_length_ = 0;
size_t queue_length_ = 0;
std::recursive_mutex message_mutex_;
};
@@ -121,14 +121,14 @@ void logAddImpl(
log_state.queue_tail_ = &newmsg->next;
++log_state.queue_length_;
if (log_state.queue_length_ > TR_LOG_MAX_QUEUE_LENGTH)
if (log_state.queue_length_ > TrLogMaxQueueLength)
{
tr_log_message* old = log_state.queue_;
log_state.queue_ = old->next;
old->next = nullptr;
tr_logFreeQueue(old);
--log_state.queue_length_;
TR_ASSERT(log_state.queue_length_ == TR_LOG_MAX_QUEUE_LENGTH);
TR_ASSERT(log_state.queue_length_ == TrLogMaxQueueLength);
}
}
else