build: lint header files with clang-tidy (#7527)

* build: clang-tidy headers when building libtransmission

* chore: revert `= default` workaround

It was introduced in 6909ec0bad to fix build issues with macOS 10.14. We
no longer support that version.

* fix: clang-tidy warnings for libtransmission

* build: clang-tidy headers when building tests

* fix: clang-tidy warnings for tests

* build: clang-tidy headers when building qt

* code review: don't manually edit mime-types.h

* code review: unify variable naming for static private members
This commit is contained in:
Yat Ho
2025-05-08 05:10:16 +08:00
committed by GitHub
parent f0c8fd689a
commit 08ec7fb7c7
78 changed files with 368 additions and 237 deletions

View File

@@ -62,8 +62,8 @@ struct tr_url_query_view
struct iterator
{
std::pair<std::string_view, std::string_view> keyval = std::make_pair(std::string_view{ "" }, std::string_view{ "" });
std::string_view remain = "";
std::pair<std::string_view, std::string_view> keyval;
std::string_view remain;
iterator& operator++();
@@ -90,7 +90,7 @@ struct tr_url_query_view
[[nodiscard]] iterator begin() const;
[[nodiscard]] constexpr iterator end() const
[[nodiscard]] static constexpr iterator end()
{
return iterator{};
}