Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-04-18 07:56:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: sonarcloud warnings (#2350)

Browse Source 
* fix: use-init-statement sonarcloud warning

* fix: use-init-statement sonarcloud warning

* fix: conversion-loses-precision sonarcloud warning

* fix: use std::string_view::npos sonarcoud warning

* fix: refactor code to not nest more than 3x sonarcloud warning

* fix: conversion-loses-precision sonarcloud warning

* fix: use init-statement sonarcloud warning

* fix: global variables should be const sonarcloud warning

* fix: conversion-loses-precision sonarcloud warning

* refactor: reduce complexity in doScrape()
This commit is contained in:
Charles Kerr
2021-12-26 18:32:36 -06:00
committed by GitHub
parent 6149870540
commit 0b095dc258
6 changed files with 114 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
qt/AddData.cc
View File

@@ -25,13 +25,12 @@ namespace
QString getNameFromMetainfo(QByteArray const& benc)
{
auto metainfo = tr_torrent_metainfo{};
if (metainfo.parseBenc({ benc.constData(), size_t(benc.size()) }))
if (!metainfo.parseBenc({ benc.constData(), size_t(benc.size()) }))
{
auto const& mname = metainfo.name();
return QString::fromUtf8(std::data(mname), std::size(mname));
return {};
}
return {};
return QString::fromStdString(metainfo.name());
}
} // namespace