Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-20 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: coverity warnings (#4687)

Browse Source 
* fix: minor tr_error leak warning in tests

* fix: socket leak in tr_globalIPv6()
This commit is contained in:
Charles Kerr
2023-01-29 16:49:59 -06:00
committed by GitHub
parent 724a0f48f0
commit 0e5f7f86d7
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libtransmission/net.cc
View File

@@ -447,6 +447,7 @@ namespace global_ipv6_helpers
{ {
if (auto const addrport = tr_address::from_sockaddr(reinterpret_cast<sockaddr*>(&src_ss)); addrport) if (auto const addrport = tr_address::from_sockaddr(reinterpret_cast<sockaddr*>(&src_ss)); addrport)
{ {
evutil_closesocket(sock);
errno = save; errno = save;
return addrport->first; return addrport->first;
} }

2
tests/libtransmission/file-test.cc
View File

@@ -225,7 +225,7 @@ TEST_F(FileTest, getInfo)
// Can't get info of non-existent file/directory // Can't get info of non-existent file/directory
tr_error* err = nullptr; tr_error* err = nullptr;
auto info = tr_sys_path_get_info(path1, 0, &err); auto info = tr_sys_path_get_info(path1, 0, &err);
ASSERT_FALSE(info.has_value()); EXPECT_FALSE(info.has_value());
EXPECT_NE(nullptr, err); EXPECT_NE(nullptr, err);
tr_error_clear(&err); tr_error_clear(&err);