Refactor RPC requests code for proper queueing (patch by intelfx @ GH-10)

This refactoring is driven by the need to be able to do true queued RPC calls
(where each successive call uses the result of the previous).

Currently, such queueing of requests is done by assigning them special "magic"
tag numbers, which are then intercepted in one big switch() statement and acted
upon. This (aside from making code greatly unclear) effectively makes each such
queue a singleton, because state passing is restricted to global variables.

We refactor RpcClient to assign an unique tag to each remote call, and then
abstract all the call<->response matching with Qt's future/promise mechanism.

Finally, we introduce a "RPC request queue" class (RpcQueue) which is built on
top of QFutureWatcher and C++11's <functional> library. This class maintains
a queue of functions, where each function receives an RPC response, does
necessary processing, performs another call and finally returns its future.
This commit is contained in:
Mike Gelfand
2016-04-19 20:41:59 +00:00
parent 66285a525b
commit 2b917de65b
14 changed files with 678 additions and 414 deletions

View File

@@ -1,5 +1,5 @@
/*
* This file Copyright (C) 2012-2015 Mnemosyne LLC
* This file Copyright (C) 2012-2016 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
* or any future license endorsed by Mnemosyne LLC.
@@ -33,6 +33,7 @@ class AddData
QByteArray toBase64 () const;
QString readableName () const;
QString readableShortName () const;
static bool isSupported (const QString& str) { return AddData (str).type != NONE; }