Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-25 04:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fix sonarcloud "use enum class" code smells (#2590)

Browse Source 
* refactor: prefer constexpr over enum for GUI_PAD values

* refactor: prefer constexpr over enum for PrefsDialog values

* refactor: prefer constexpr over enum for StatsDialog values

* refactor: use enum class for GtrUnicode types

* refactor: prefer constexpr over enum for BT peer msg codes

* refactor: use enum class for TrMakemetaResult

* refactor: prefer constexpr over enum for BT metadata message types

* refactor: use enum class for AwaitingBt

* refactor: use enum class for EncryptionPreference

* refactor: use enum class for TrFormat in rpcimpl

* refactor: prefer constexpr over enum for QApp intervals

* refactor: prefer constexpr over enum for tr_resume bitfields

* refactor: prefer constexpr over enum for Qt/TrFileModel bitfields

* refactor: remove obsolete TODO comment in announce-list
This commit is contained in:
Charles Kerr
2022-02-08 20:25:19 -06:00
committed by GitHub
parent a92af9193e
commit 318d60b72d
25 changed files with 575 additions and 575 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gtk/MakeDialog.cc
View File

@@ -111,23 +111,23 @@ bool MakeProgressDialog::onProgressDialogRefresh()
{
str = gtr_sprintf(_("Creating \"%s\""), base);
}
else if (builder_.result == TR_MAKEMETA_OK)
else if (builder_.result == TrMakemetaResult::OK)
{
str = gtr_sprintf(_("Created \"%s\"!"), base);
}
else if (builder_.result == TR_MAKEMETA_URL)
{
str = gtr_sprintf(_("Error: invalid announce URL \"%s\""), builder_.errfile);
}
else if (builder_.result == TR_MAKEMETA_CANCELLED)
else if (builder_.result == TrMakemetaResult::CANCELLED)
{
str = _("Cancelled");
}
else if (builder_.result == TR_MAKEMETA_IO_READ)
else if (builder_.result == TrMakemetaResult::ERR_URL)
{
str = gtr_sprintf(_("Error: invalid announce URL \"%s\""), builder_.errfile);
}
else if (builder_.result == TrMakemetaResult::ERR_IO_READ)
{
str = gtr_sprintf(_("Error reading \"%s\": %s"), builder_.errfile, Glib::strerror(builder_.my_errno));
}
else if (builder_.result == TR_MAKEMETA_IO_WRITE)
else if (builder_.result == TrMakemetaResult::ERR_IO_WRITE)
{
str = gtr_sprintf(_("Error writing \"%s\": %s"), builder_.errfile, Glib::strerror(builder_.my_errno));
}
@@ -155,7 +155,7 @@ bool MakeProgressDialog::onProgressDialogRefresh()
/* buttons */
set_response_sensitive(Gtk::RESPONSE_CANCEL, !builder_.isDone);
set_response_sensitive(Gtk::RESPONSE_CLOSE, builder_.isDone);
set_response_sensitive(Gtk::RESPONSE_ACCEPT, builder_.isDone && !builder_.result);
set_response_sensitive(Gtk::RESPONSE_ACCEPT, builder_.isDone && builder_.result == TrMakemetaResult::OK);
return true;
}
@@ -241,7 +241,7 @@ void MakeDialog::Impl::makeProgressDialog(std::string const& target)
{
progress_dialog_.reset();
if (!builder_->result)
if (builder_->result == TrMakemetaResult::OK)
{
dialog_.hide();
}