Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-27 05:38:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: fix sonarcloud "use enum class" code smells (#2590)

Browse Source 
* refactor: prefer constexpr over enum for GUI_PAD values

* refactor: prefer constexpr over enum for PrefsDialog values

* refactor: prefer constexpr over enum for StatsDialog values

* refactor: use enum class for GtrUnicode types

* refactor: prefer constexpr over enum for BT peer msg codes

* refactor: use enum class for TrMakemetaResult

* refactor: prefer constexpr over enum for BT metadata message types

* refactor: use enum class for AwaitingBt

* refactor: use enum class for EncryptionPreference

* refactor: use enum class for TrFormat in rpcimpl

* refactor: prefer constexpr over enum for QApp intervals

* refactor: prefer constexpr over enum for tr_resume bitfields

* refactor: prefer constexpr over enum for Qt/TrFileModel bitfields

* refactor: remove obsolete TODO comment in announce-list
This commit is contained in:
Charles Kerr
2022-02-08 20:25:19 -06:00
committed by GitHub
parent a92af9193e
commit 318d60b72d
25 changed files with 575 additions and 575 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
macosx/CreatorWindowController.mm
View File

@@ -587,7 +587,7 @@ NSMutableSet* creatorWindowControllerSet = nil;
NSAlert* alert;
switch (fInfo->result)
{
case TR_MAKEMETA_OK:
case TrMakemetaResult::OK:
if (fOpenWhenCreated)
{
NSDictionary* dict = @{ @"File" : fLocation.path, @"Path" : fPath.URLByDeletingLastPathComponent.path };
@@ -597,7 +597,7 @@ NSMutableSet* creatorWindowControllerSet = nil;
[self.window close];
break;
case TR_MAKEMETA_CANCELLED:
case TrMakemetaResult::CANCELLED:
[self.window close];
break;
@@ -608,14 +608,14 @@ NSMutableSet* creatorWindowControllerSet = nil;
fLocation.lastPathComponent];
alert.alertStyle = NSAlertStyleWarning;
if (fInfo->result == TR_MAKEMETA_IO_READ)
if (fInfo->result == TrMakemetaResult::ERR_IO_READ)
{
alert.informativeText = [NSString
stringWithFormat:NSLocalizedString(@"Could not read \"%s\": %s.", "Create torrent -> failed -> warning"),
fInfo->errfile,
strerror(fInfo->my_errno)];
}
else if (fInfo->result == TR_MAKEMETA_IO_WRITE)
else if (fInfo->result == TrMakemetaResult::ERR_IO_WRITE)
{
alert.informativeText = [NSString
stringWithFormat:NSLocalizedString(@"Could not write \"%s\": %s.", "Create torrent -> failed -> warning"),