Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: cppcoreguidelines-avoid-goto (#3841)

Browse Source 
* refactor: do not use goto in file-win32.cc

* refactor: do not use goto in subprocess-posix.cc

* refactor: do not use goto in peer-io.cc

* build: add cppcoreguidelines-avoid-goto to libtransmission/.clang-tidy
This commit is contained in:
Charles Kerr
2022-09-23 08:39:13 -05:00
committed by GitHub
parent 56e0a1bda8
commit 326d9f3daf
5 changed files with 118 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libtransmission/subprocess-posix.cc
View File

@@ -53,8 +53,7 @@ static void set_system_error(tr_error** error, int code, std::string_view what)
static bool tr_spawn_async_in_child(
char const* const* cmd,
std::map<std::string_view, std::string_view> const& env,
std::string_view work_dir,
int pipe_fd)
std::string_view work_dir)
{
auto key_sz = std::string{};
auto val_sz = std::string{};
@@ -66,25 +65,21 @@ static bool tr_spawn_async_in_child(
if (setenv(key_sz.c_str(), val_sz.c_str(), 1) != 0)
{
goto FAIL;
return false;
}
}
if (!std::empty(work_dir) && chdir(tr_pathbuf{ work_dir }) == -1)
{
goto FAIL;
return false;
}
if (execvp(cmd[0], const_cast<char* const*>(cmd)) == -1)
{
goto FAIL;
return false;
}
return true;
FAIL:
(void)write(pipe_fd, &errno, sizeof(errno));
return false;
}
static bool tr_spawn_async_in_parent(int pipe_fd, tr_error** error)
@@ -168,8 +163,9 @@ bool tr_spawn_async(
{
close(pipe_fds[0]);
if (!tr_spawn_async_in_child(cmd, env, work_dir, pipe_fds[1]))
if (!tr_spawn_async_in_child(cmd, env, work_dir))
{
(void)write(pipe_fds[1], &errno, sizeof(errno));
_exit(0);
}
}