Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: more sonarcloud warnings (#2324)

Browse Source
This commit is contained in:
Charles Kerr
2021-12-16 23:47:51 -06:00
committed by GitHub
parent b9406dfebb
commit 37a8046ed5
19 changed files with 91 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libtransmission/rpcimpl.cc
View File

@@ -119,9 +119,8 @@ static auto getTorrents(tr_session* session, tr_variant* args)
auto id = int64_t{};
auto sv = std::string_view{};
tr_variant* ids = nullptr;
if (tr_variantDictFindList(args, TR_KEY_ids, &ids))
if (tr_variant* ids = nullptr; tr_variantDictFindList(args, TR_KEY_ids, &ids))
{
size_t const n = tr_variantListSize(ids);
torrents.reserve(n);
@@ -148,8 +147,7 @@ static auto getTorrents(tr_session* session, tr_variant* args)
}
else if (tr_variantDictFindInt(args, TR_KEY_ids, &id) || tr_variantDictFindInt(args, TR_KEY_id, &id))
{
tr_torrent* const tor = tr_torrentFindFromId(session, id);
if (tor != nullptr)
if (auto* const tor = tr_torrentFindFromId(session, id); tor != nullptr)
{
torrents.push_back(tor);
}
@@ -165,7 +163,7 @@ static auto getTorrents(tr_session* session, tr_variant* args)
std::begin(session->torrents),
std::end(session->torrents),
std::back_inserter(torrents),
[&cutoff](tr_torrent* tor) { return tor->anyDate >= cutoff; });
[&cutoff](auto const* tor) { return tor->anyDate >= cutoff; });
}
else
{
@@ -454,7 +452,7 @@ static void addTrackerStats(tr_tracker_view const& tracker, tr_variant* list)
tr_variantDictAddInt(d, TR_KEY_tier, tracker.tier);
}
static void addPeers(tr_torrent* tor, tr_variant* list)
static void addPeers(tr_torrent const* tor, tr_variant* list)
{
auto peerCount = int{};
tr_peer_stat* peers = tr_torrentPeers(tor, &peerCount);