Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-05-08 09:39:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

make sure a info tab is loaded the first time it's shown

Browse Source
This commit is contained in:
Mitchell Livingston
2010-03-07 01:40:32 +00:00
parent 7bf62b1311
commit 41f29d45eb
7 changed files with 165 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files
macosx/InfoWindowController.m
+32 -14
View File
@@ -68,16 +68,7 @@ typedef enum
- (id) init
{
if ((self = [super initWithWindowNibName: @"InfoWindow"]))
{
fGeneralViewController = [[InfoGeneralViewController alloc] init];
fActivityViewController = [[InfoActivityViewController alloc] init];
fTrackersViewController = [[InfoTrackersViewController alloc] init];
fPeersViewController = [[InfoPeersViewController alloc] init];
fFileViewController = [[InfoFileViewController alloc] init];
fOptionsViewController = [[InfoOptionsViewController alloc] init];
}
self = [super initWithWindowNibName: @"InfoWindow"];
return self;
}
@@ -243,8 +234,6 @@ typedef enum
if (fCurrentTabTag == oldTabTag)
return;
[self updateInfoStats];
//take care of old view
CGFloat oldHeight = 0;
NSString * oldResizeSaveKey = nil;
@@ -287,37 +276,53 @@ typedef enum
}
//set new tab item
NSView * view = [self tabViewForTag: fCurrentTabTag];
#warning get titles from view controller?
NSString * resizeSaveKey = nil;
NSString * identifier, * title;
switch (fCurrentTabTag)
{
case TAB_GENERAL_TAG:
if (!fGeneralViewController)
fGeneralViewController = [[InfoGeneralViewController alloc] init];
identifier = TAB_INFO_IDENT;
title = NSLocalizedString(@"General Info", "Inspector -> title");
break;
case TAB_ACTIVITY_TAG:
if (!fActivityViewController)
fActivityViewController = [[InfoActivityViewController alloc] init];
identifier = TAB_ACTIVITY_IDENT;
title = NSLocalizedString(@"Activity", "Inspector -> title");
break;
case TAB_TRACKERS_TAG:
if (!fTrackersViewController)
fTrackersViewController = [[InfoTrackersViewController alloc] init];
identifier = TAB_TRACKER_IDENT;
title = NSLocalizedString(@"Trackers", "Inspector -> title");
resizeSaveKey = @"InspectorContentHeightTracker";
break;
case TAB_PEERS_TAG:
if (!fPeersViewController)
fPeersViewController = [[InfoPeersViewController alloc] init];
identifier = TAB_PEERS_IDENT;
title = NSLocalizedString(@"Peers", "Inspector -> title");
resizeSaveKey = @"InspectorContentHeightPeers";
break;
case TAB_FILE_TAG:
if (!fFileViewController)
fFileViewController = [[InfoFileViewController alloc] init];
identifier = TAB_FILES_IDENT;
title = NSLocalizedString(@"Files", "Inspector -> title");
resizeSaveKey = @"InspectorContentHeightFiles";
break;
case TAB_OPTIONS_TAG:
if (!fOptionsViewController)
fOptionsViewController = [[InfoOptionsViewController alloc] init];
identifier = TAB_OPTIONS_IDENT;
title = NSLocalizedString(@"Options", "Inspector -> title");
break;
@@ -335,6 +340,18 @@ typedef enum
//selected tab item
[(InfoTabButtonCell *)[fTabMatrix selectedCell] setSelectedTab: YES];
NSView * view = [self tabViewForTag: fCurrentTabTag];
//if view was just loaded - has to be a better way
[fGeneralViewController setInfoForTorrents: fTorrents];
[fActivityViewController setInfoForTorrents: fTorrents];
[fTrackersViewController setInfoForTorrents: fTorrents];
[fPeersViewController setInfoForTorrents: fTorrents];
[fFileViewController setInfoForTorrents: fTorrents];
[fOptionsViewController setInfoForTorrents: fTorrents];
[self updateInfoStats];
NSRect windowRect = [window frame], viewRect = [view frame];
if (resizeSaveKey)
@@ -367,6 +384,7 @@ typedef enum
[window setFrame: windowRect display: YES animate: oldTabTag != INVALID];
[[window contentView] addSubview: view];
[view setHidden: NO];
if ([NSApp isOnSnowLeopardOrBetter] && (fCurrentTabTag == TAB_FILE_TAG || oldTabTag == TAB_FILE_TAG)