Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-27 13:41:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues reported by clang-tidy cppcoreguidelines checks (GTK client) (#4158)

Browse Source 
* Fix `cppcoreguidelines-pro-type-cstyle-cast` clang-tidy issues

* Fix `cppcoreguidelines-pro-type-member-init` clang-tidy issues

* Fix `cppcoreguidelines-prefer-member-initializer` clang-tidy issues

* Introduce `PageBase` for `PrefsDialog` pages

This is in preparation for next PR fixing `Glib::Timer` memory
management.

* Fix `cppcoreguidelines-owning-memory` clang-tidy issues

* Fix `cppcoreguidelines-pro-bounds-array-to-pointer-decay` clang-tidy issues

* Fix `cppcoreguidelines-special-member-functions` clang-tidy issues

* Fix `cppcoreguidelines-init-variables` clang-tidy issues

* Fix `cppcoreguidelines-macro-usage` clang-tidy issues

* Fix `cppcoreguidelines-pro-bounds-constant-array-index` clang-tidy issues

* Fix `cppcoreguidelines-non-private-member-variables-in-classes` clang-tidy issues

* Fix `cppcoreguidelines-pro-type-vararg` clang-tidy issues

* Fix `cppcoreguidelines-pro-bounds-pointer-arithmetic` clang-tidy issue

* Fix `cppcoreguidelines-pro-type-reinterpret-cast` clang-tidy issues

* Fix `cppcoreguidelines-pro-type-static-cast-downcast` clang-tidy issues

* Extend clang-tidy configuration

Enable all `cppcoreguidelines` checks except for three (`avoid-magic-
numbers`, `avoid-non-const-global-variables`, `narrowing-conversions`)
which require [more] extensive refactoring and were left for later.
This commit is contained in:
Mike Gelfand
2022-11-13 18:36:16 +01:00
committed by GitHub
parent 0ecf084e0f
commit 49ce12ce38
21 changed files with 730 additions and 744 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gtk/main.cc
View File

@@ -55,7 +55,7 @@ int main(int argc, char** argv)
Gio::File::create_for_path(".");
Glib::wrap_register(
g_type_from_name("GLocalFile"),
[](GObject* object) -> Glib::ObjectBase* { return new Gio::File((GFile*)object); });
[](GObject* object) -> Glib::ObjectBase* { return new Gio::File(G_FILE(object)); });
g_type_ensure(Gio::File::get_type());
/* default settings */
@@ -93,7 +93,7 @@ int main(int argc, char** argv)
fmt::print(
stderr,
_("Run '{program} --help' to see a full list of available command line options.\n"),
fmt::arg("program", argv[0]));
fmt::arg("program", *argv));
return 1;
}