Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: coverity warnings, sonarcloud code smells (#4232)

Browse Source
This commit is contained in:
Charles Kerr
2022-11-24 10:17:02 -06:00
committed by GitHub
parent ead71e8fd3
commit 554ba06ae2
11 changed files with 70 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gtk/FaviconCache.cc
View File

@@ -94,14 +94,11 @@ bool favicon_web_done_idle_cb(std::unique_ptr<favicon_data> fav)
auto* const session = fav->session;
auto const next_url = get_url(fav->host, fav->type);
tr_sessionFetch(session, { next_url.raw(), favicon_web_done_cb, fav.release() });
return false;
}
// Not released into the next web request, means we're done trying (even if `pixbuf` is still invalid)
if (fav != nullptr)
{
fav->func(pixbuf);
}
fav->func(pixbuf);
return false;
}