Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-20 18:38:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Web client add licensing info (#1481)

Browse Source 
* chore: add '@license' tag to web sources' comments

Webpack's tersify plugin looks for that JSDoc tag in order to decide
which comments to extract into the generated license file.

* chore: address sonarcloud.io warnings

* chore: address sonarcloud.io code smells

* fixup! chore: address sonarcloud.io warnings
This commit is contained in:
Charles Kerr
2020-10-25 16:13:48 -05:00
committed by GitHub
parent cd453764b1
commit 61d221c8bb
28 changed files with 129 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
web/src/overflow-menu.js
View File

@@ -1,4 +1,6 @@
/*
/**
* @license
*
* This file Copyright (C) 2020 Mnemosyne LLC
*
* It may be used under the GNU GPL versions 2 or 3
@@ -10,6 +12,25 @@ import { Prefs } from './prefs.js';
import { RPC } from './remote.js';
import { OutsideClickListener, setEnabled } from './utils.js';
function make_section(classname, title) {
const section = document.createElement('fieldset');
section.classList.add('section', classname);
const legend = document.createElement('legend');
legend.classList.add('title');
legend.textContent = title;
section.append(legend);
return section;
}
function make_button(parent, text, action, on_click) {
const button = document.createElement('button');
button.textContent = text;
button.addEventListener('click', on_click);
parent.append(button);
button.dataset.action = action;
return button;
}
export class OverflowMenu extends EventTarget {
constructor(session_manager, prefs, remote, action_manager) {
super();
@@ -123,29 +144,8 @@ export class OverflowMenu extends EventTarget {
_create(session_properties) {
const actions = {};
const on_click = this._onClick.bind(this);
const elements = {};
const make_section = (classname, title) => {
const section = document.createElement('fieldset');
section.classList.add('section', classname);
const legend = document.createElement('legend');
legend.classList.add('title');
legend.textContent = title;
section.append(legend);
return section;
};
const make_button = (parent, text, action) => {
const e = document.createElement('button');
e.textContent = text;
e.addEventListener('click', on_click);
parent.append(e);
if (action) {
e.dataset.action = action;
}
return e;
};
const on_click = this._onClick.bind(this);
const root = document.createElement('div');
root.classList.add('overflow-menu', 'popup');
@@ -418,7 +418,7 @@ export class OverflowMenu extends EventTarget {
'start-all-torrents',
]) {
const text = this.action_manager.text(action_name);
actions[action_name] = make_button(section, text, action_name);
actions[action_name] = make_button(section, text, action_name, on_click);
}
section = make_section('info', 'Info');
@@ -433,7 +433,7 @@ export class OverflowMenu extends EventTarget {
'show-statistics-dialog',
]) {
const text = this.action_manager.text(action_name);
actions[action_name] = make_button(options, text, action_name);
actions[action_name] = make_button(options, text, action_name, on_click);
}
section = make_section('links', 'Links');