Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-02-15 07:26:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: some errors are not returned in tr_sys_path_get_capacity() (#8248)

Browse Source 
* fix: some errors are not returned in `tr_sys_path_get_capacity()`

* test: disable well-formed free_space tests

There are no reliable way to test them.
This commit is contained in:
Yat Ho
2026-01-29 03:14:44 +08:00
committed by GitHub
parent b68fc15eb0
commit 63d6d670fd
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libtransmission/file-capacity.cc
View File

@@ -518,7 +518,7 @@ std::optional<tr_sys_path_capacity> tr_sys_path_get_capacity(std::string_view pa
error = &local_error; error = &local_error;
} }
auto const info = tr_sys_path_get_info(path, 0, &local_error); auto const info = tr_sys_path_get_info(path, 0, error);
if (!info) if (!info)
{ {
return {}; return {};

4
tests/libtransmission/rpc-test.cc
View File

@@ -851,7 +851,7 @@ constexpr std::string_view WellFormedResponse = R"json({
} }
})json"; })json";
TEST_F(RpcTest, wellFormedFreeSpace) TEST_F(RpcTest, DISABLED_wellFormedFreeSpace)
{ {
auto constexpr Input = WellFormedRequest; auto constexpr Input = WellFormedRequest;
auto constexpr Expected = WellFormedResponse; auto constexpr Expected = WellFormedResponse;
@@ -879,7 +879,7 @@ constexpr std::string_view WellFormedLegacyResponse = R"json({
#undef RPC_NON_EXISTENT_PATH #undef RPC_NON_EXISTENT_PATH
TEST_F(RpcTest, wellFormedLegacyFreeSpace) TEST_F(RpcTest, DISABLED_wellFormedLegacyFreeSpace)
{ {
auto constexpr Input = WellFormedLegacyRequest; auto constexpr Input = WellFormedLegacyRequest;
auto constexpr Expected = WellFormedLegacyResponse; auto constexpr Expected = WellFormedLegacyResponse;