Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-25 04:45:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

#5802: Don't make assumptions of remote path validity in transmission-remote

Browse Source 
Defer validity checks until path gets to the remote side, where they
actually make sense. Add simple checks for download directory path to
ensure it's not relative, since one cannot know what current working
directory of the remote process is.
This commit is contained in:
Mike Gelfand
2015-10-20 21:22:19 +00:00
parent ca21c1f230
commit 650db1f46e
6 changed files with 95 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
daemon/remote.c
View File

@@ -490,43 +490,6 @@ static char * netrc = NULL;
static char * sessionId = NULL;
static bool UseSSL = false;
static char*
tr_getcwd (void)
{
char * result;
tr_error * error = NULL;
result = tr_sys_dir_get_current (&error);
if (result == NULL)
{
fprintf (stderr, "getcwd error: \"%s\"", error->message);
tr_error_free (error);
result = tr_strdup ("");
}
return result;
}
static char*
absolutify (const char * path)
{
char * buf;
if (*path == '/')
{
buf = tr_strdup (path);
}
else
{
char * cwd = tr_getcwd ();
buf = tr_buildPath (cwd, path, NULL);
tr_free (cwd);
}
return buf;
}
static char*
getEncodedMetainfo (const char * filename)
{
@@ -2253,14 +2216,8 @@ processArgs (const char * rpcurl, int argc, const char ** argv)
}
case 'w':
{
char * path = absolutify (optarg);
if (tadd)
tr_variantDictAddStr (tr_variantDictFind (tadd, TR_KEY_arguments), TR_KEY_download_dir, path);
else {
tr_variant * args = ensure_sset (&sset);
tr_variantDictAddStr (args, TR_KEY_download_dir, path);
}
tr_free (path);
tr_variant * args = tadd ? tr_variantDictFind (tadd, TR_KEY_arguments) : ensure_sset (&sset);
tr_variantDictAddStr (args, TR_KEY_download_dir, optarg);
break;
}
case 850: