Sonarcloud warnings 3 (#1498)

* chore: use ClassName:: for calling static methods

* chore: prefer to initialize member data in the class initializer
This commit is contained in:
Charles Kerr
2020-11-01 19:13:32 -06:00
committed by GitHub
parent 19e52d8b9a
commit 73fdd722a7
44 changed files with 339 additions and 435 deletions

View File

@@ -14,7 +14,7 @@
namespace
{
int itemColumnSpan(QGridLayout* layout, QLayoutItem const* item)
int itemColumnSpan(QGridLayout const* layout, QLayoutItem const* item)
{
for (int i = 0, count = layout->count(); i < count; ++i)
{
@@ -59,15 +59,15 @@ bool ColumnResizer::eventFilter(QObject* object, QEvent* event)
return QObject::eventFilter(object, event);
}
void ColumnResizer::update()
void ColumnResizer::update() const
{
int max_width = 0;
for (QGridLayout* const layout : layouts_)
for (QGridLayout const* const layout : layouts_)
{
for (int i = 0, count = layout->rowCount(); i < count; ++i)
{
QLayoutItem* item = layout->itemAtPosition(i, 0);
QLayoutItem const* const item = layout->itemAtPosition(i, 0);
if (item == nullptr || itemColumnSpan(layout, item) > 1)
{