Sonarcloud warnings 3 (#1498)

* chore: use ClassName:: for calling static methods

* chore: prefer to initialize member data in the class initializer
This commit is contained in:
Charles Kerr
2020-11-01 19:13:32 -06:00
committed by GitHub
parent 19e52d8b9a
commit 73fdd722a7
44 changed files with 339 additions and 435 deletions

View File

@@ -61,10 +61,6 @@ private:
// Internally stored error handler function. Takes the last response future and returns nothing.
using ErrorHandlerFunction = std::function<void (RpcResponseFuture const&)>;
private slots:
void stepFinished();
private:
void runNext(RpcResponseFuture const& response);
// These overloads convert various forms of input closures to what we store internally.
@@ -143,7 +139,6 @@ private:
};
}
private:
Tag const tag_;
static Tag next_tag;
bool tolerate_errors_ = {};
@@ -151,4 +146,7 @@ private:
QQueue<QPair<QueuedFunction, ErrorHandlerFunction>> queue_;
ErrorHandlerFunction next_error_handler_;
QFutureWatcher<RpcResponse> future_watcher_;
private slots:
void stepFinished();
};